Re: [PATCH 1/4] ASoC: hdmi-codec: Add an op to set callback function for plug event

2019-07-09 Thread Cheng-yi Chiang
On Mon, Jul 8, 2019 at 1:03 PM Cheng-yi Chiang wrote: > > On Fri, Jul 5, 2019 at 8:12 PM Mark Brown wrote: > > > > On Fri, Jul 05, 2019 at 03:08:37PM +0800, Tzung-Bi Shih wrote: > > > On Fri, Jul 5, 2019 at 12:26 PM Cheng-Yi Chiang > > > wrote: > > > > > > +typedef void (*hdmi_codec_plugged_cb)

Re: [PATCH 1/4] ASoC: hdmi-codec: Add an op to set callback function for plug event

2019-07-09 Thread Cheng-yi Chiang
On Tue, Jul 9, 2019 at 7:47 PM Cezary Rojewski wrote: > > On 2019-07-05 06:26, Cheng-Yi Chiang wrote: > > +static void hdmi_codec_jack_report(struct hdmi_codec_priv *hcp, > > +unsigned int jack_status) > > +{ > > + if (!hcp->jack) > > + return; > > +

Re: [PATCH 1/4] ASoC: hdmi-codec: Add an op to set callback function for plug event

2019-07-09 Thread Cezary Rojewski
On 2019-07-05 06:26, Cheng-Yi Chiang wrote: +static void hdmi_codec_jack_report(struct hdmi_codec_priv *hcp, + unsigned int jack_status) +{ + if (!hcp->jack) + return; + + if (jack_status != hcp->jack_status) { + snd_soc_jac

Re: [PATCH 1/4] ASoC: hdmi-codec: Add an op to set callback function for plug event

2019-07-07 Thread Cheng-yi Chiang
On Fri, Jul 5, 2019 at 8:12 PM Mark Brown wrote: > > On Fri, Jul 05, 2019 at 03:08:37PM +0800, Tzung-Bi Shih wrote: > > On Fri, Jul 5, 2019 at 12:26 PM Cheng-Yi Chiang > > wrote: > > > > +typedef void (*hdmi_codec_plugged_cb)(struct platform_device *dev, > > > +

Re: [PATCH 1/4] ASoC: hdmi-codec: Add an op to set callback function for plug event

2019-07-05 Thread Mark Brown
On Fri, Jul 05, 2019 at 03:08:37PM +0800, Tzung-Bi Shih wrote: > On Fri, Jul 5, 2019 at 12:26 PM Cheng-Yi Chiang wrote: > > +typedef void (*hdmi_codec_plugged_cb)(struct platform_device *dev, > > + bool plugged); > > + > The callback prototype is "weird" by st

Re: [PATCH 1/4] ASoC: hdmi-codec: Add an op to set callback function for plug event

2019-07-05 Thread Tzung-Bi Shih
On Fri, Jul 5, 2019 at 12:26 PM Cheng-Yi Chiang wrote: > diff --git a/include/sound/hdmi-codec.h b/include/sound/hdmi-codec.h > index 7fea496f1f34..26c02abb8eba 100644 > --- a/include/sound/hdmi-codec.h > +++ b/include/sound/hdmi-codec.h > @@ -47,6 +47,9 @@ struct hdmi_codec_params { > int

[PATCH 1/4] ASoC: hdmi-codec: Add an op to set callback function for plug event

2019-07-04 Thread Cheng-Yi Chiang
Add an op in hdmi_codec_ops so codec driver can register callback function to handle plug event. Driver in DRM can use this callback function to report connector status. Signed-off-by: Cheng-Yi Chiang --- include/sound/hdmi-codec.h| 16 +++ sound/soc/codecs/hdmi-codec.c | 52 +++