Hi Hans,
> >> +static int gma_backlight_update_status(struct backlight_device *bd)
> >> +{
> >> + struct drm_device *dev = bl_get_data(bd);
> >> + int level = bd->props.brightness;
> >
> > Here backlight_get_brightness(bd) should be used.
>
> Ack, but the old set methods all 3 used:
>
>
Hi Sam,
On 9/11/22 13:48, Sam Ravnborg wrote:
> Hi Hans,
>
> just a few minor things. See comments.
> I like the diff - removes much more than it adds.
I'm glad you like it and thank you for the review.
> On Sat, Sep 10, 2022 at 10:50:58PM +0200, Hans de Goede wrote:
>> Refactor backlight suppo
Hi Hans,
just a few minor things. See comments.
I like the diff - removes much more than it adds.
Sam
On Sat, Sep 10, 2022 at 10:50:58PM +0200, Hans de Goede wrote:
> Refactor backlight support so that the gma_backlight_enable() /
> gma_backlight_disable() / gma_backlight_set() functions
Refactor backlight support so that the gma_backlight_enable() /
gma_backlight_disable() / gma_backlight_set() functions used by
the Opregion handle will also work if no backlight_device gets
registered.
This is a preparation patch for not registering the gma500's own backlight
device when acpi_vid