Re: [Intel-gfx] [PATCH 1/4] drm/i915/gt: Remove platform comments from workarounds

2023-01-16 Thread Tvrtko Ursulin
On 12/01/2023 21:42, Lucas De Marchi wrote: On Thu, Jan 05, 2023 at 01:35:52PM +, Tvrtko Ursulin wrote: Okay to sum it up below with some final notes.. On 04/01/2023 19:34, Matt Roper wrote: On Wed, Jan 04, 2023 at 09:58:13AM +, Tvrtko Ursulin wrote: On 23/12/2022 18:28, Lucas De

Re: [Intel-gfx] [PATCH 1/4] drm/i915/gt: Remove platform comments from workarounds

2023-01-12 Thread Lucas De Marchi
On Thu, Jan 05, 2023 at 01:35:52PM +, Tvrtko Ursulin wrote: Okay to sum it up below with some final notes.. On 04/01/2023 19:34, Matt Roper wrote: On Wed, Jan 04, 2023 at 09:58:13AM +, Tvrtko Ursulin wrote: On 23/12/2022 18:28, Lucas De Marchi wrote: On Fri, Dec 23, 2022 at 09:02:35

Re: [PATCH 1/4] drm/i915/gt: Remove platform comments from workarounds

2023-01-06 Thread Matt Roper
On Thu, Jan 05, 2023 at 01:35:52PM +, Tvrtko Ursulin wrote: > > Okay to sum it up below with some final notes.. > > On 04/01/2023 19:34, Matt Roper wrote: > > On Wed, Jan 04, 2023 at 09:58:13AM +, Tvrtko Ursulin wrote: > > > > > > On 23/12/2022 18:28, Lucas De Marchi wrote: > > > > On Fr

Re: [PATCH 1/4] drm/i915/gt: Remove platform comments from workarounds

2023-01-05 Thread Tvrtko Ursulin
Okay to sum it up below with some final notes.. On 04/01/2023 19:34, Matt Roper wrote: On Wed, Jan 04, 2023 at 09:58:13AM +, Tvrtko Ursulin wrote: On 23/12/2022 18:28, Lucas De Marchi wrote: On Fri, Dec 23, 2022 at 09:02:35AM +, Tvrtko Ursulin wrote: On 22/12/2022 15:55, Lucas De

Re: [PATCH 1/4] drm/i915/gt: Remove platform comments from workarounds

2023-01-04 Thread Matt Roper
On Wed, Jan 04, 2023 at 09:58:13AM +, Tvrtko Ursulin wrote: > > On 23/12/2022 18:28, Lucas De Marchi wrote: > > On Fri, Dec 23, 2022 at 09:02:35AM +, Tvrtko Ursulin wrote: > > > > > > On 22/12/2022 15:55, Lucas De Marchi wrote: > > > > On Thu, Dec 22, 2022 at 10:27:00AM +, Tvrtko Ursu

Re: [PATCH 1/4] drm/i915/gt: Remove platform comments from workarounds

2023-01-04 Thread Tvrtko Ursulin
On 23/12/2022 18:28, Lucas De Marchi wrote: On Fri, Dec 23, 2022 at 09:02:35AM +, Tvrtko Ursulin wrote: On 22/12/2022 15:55, Lucas De Marchi wrote: On Thu, Dec 22, 2022 at 10:27:00AM +, Tvrtko Ursulin wrote: On 22/12/2022 08:25, Lucas De Marchi wrote: The comments are redundant to

Re: [PATCH 1/4] drm/i915/gt: Remove platform comments from workarounds

2023-01-03 Thread Matt Roper
On Fri, Dec 23, 2022 at 10:28:07AM -0800, Lucas De Marchi wrote: > On Fri, Dec 23, 2022 at 09:02:35AM +, Tvrtko Ursulin wrote: > > > > On 22/12/2022 15:55, Lucas De Marchi wrote: > > > On Thu, Dec 22, 2022 at 10:27:00AM +, Tvrtko Ursulin wrote: > > > > > > > > On 22/12/2022 08:25, Lucas D

Re: [PATCH 1/4] drm/i915/gt: Remove platform comments from workarounds

2022-12-23 Thread Lucas De Marchi
On Fri, Dec 23, 2022 at 09:02:35AM +, Tvrtko Ursulin wrote: On 22/12/2022 15:55, Lucas De Marchi wrote: On Thu, Dec 22, 2022 at 10:27:00AM +, Tvrtko Ursulin wrote: On 22/12/2022 08:25, Lucas De Marchi wrote: The comments are redundant to the checks being done to apply the workarounds

Re: [PATCH 1/4] drm/i915/gt: Remove platform comments from workarounds

2022-12-23 Thread Tvrtko Ursulin
On 22/12/2022 15:55, Lucas De Marchi wrote: On Thu, Dec 22, 2022 at 10:27:00AM +, Tvrtko Ursulin wrote: On 22/12/2022 08:25, Lucas De Marchi wrote: The comments are redundant to the checks being done to apply the workarounds and very often get outdated as workarounds need to be extended

Re: [PATCH 1/4] drm/i915/gt: Remove platform comments from workarounds

2022-12-22 Thread Lucas De Marchi
On Thu, Dec 22, 2022 at 10:27:00AM +, Tvrtko Ursulin wrote: On 22/12/2022 08:25, Lucas De Marchi wrote: The comments are redundant to the checks being done to apply the workarounds and very often get outdated as workarounds need to be extended to new platforms or steppings. Remove them alt

Re: [PATCH 1/4] drm/i915/gt: Remove platform comments from workarounds

2022-12-22 Thread Tvrtko Ursulin
On 22/12/2022 08:25, Lucas De Marchi wrote: The comments are redundant to the checks being done to apply the workarounds and very often get outdated as workarounds need to be extended to new platforms or steppings. Remove them altogether with the following matches (platforms extracted from int

[PATCH 1/4] drm/i915/gt: Remove platform comments from workarounds

2022-12-22 Thread Lucas De Marchi
The comments are redundant to the checks being done to apply the workarounds and very often get outdated as workarounds need to be extended to new platforms or steppings. Remove them altogether with the following matches (platforms extracted from intel_workarounds.c): find drivers/gpu/drm