[PATCH 1/5] fbdev: Hot-unplug firmware fb devices on forced removal

2022-01-25 Thread Thomas Zimmermann
Hot-unplug all firmware-framebuffer devices as part of removing them via remove_conflicting_framebuffers() et al. Releases all memory regions to be acquired by native drivers. Firmware, such as EFI, install a framebuffer while posting the computer. After removing the firmware-framebuffer device

Re: [PATCH 1/5] fbdev: Hot-unplug firmware fb devices on forced removal

2022-01-24 Thread Zack Rusin
On Mon, 2022-01-24 at 13:36 +0100, Thomas Zimmermann wrote: > Hot-unplug all firmware-framebuffer devices as part of removing > them via remove_conflicting_framebuffers() et al. Releases all > memory regions to be acquired by native drivers. > > Firmware, such as EFI, install a framebuffer while

Re: [PATCH 1/5] fbdev: Hot-unplug firmware fb devices on forced removal

2022-01-24 Thread Javier Martinez Canillas
On 1/24/22 15:19, Thomas Zimmermann wrote: [snip] >>> + if (dev_is_platform(dev)) { >> >> In do_register_framebuffer() creating the fb%d is not a fatal error. It would >> be safer to do if (!IS_ERR_OR_NULL(dev) && dev_is_platform(dev)) instead >> here. >> >>

Re: [PATCH 1/5] fbdev: Hot-unplug firmware fb devices on forced removal

2022-01-24 Thread Thomas Zimmermann
Hi Am 24.01.22 um 14:52 schrieb Javier Martinez Canillas: Hello Thomas, Thanks for the patch. On 1/24/22 13:36, Thomas Zimmermann wrote: Hot-unplug all firmware-framebuffer devices as part of removing them via remove_conflicting_framebuffers() et al. Releases all memory regions to be

Re: [PATCH 1/5] fbdev: Hot-unplug firmware fb devices on forced removal

2022-01-24 Thread Javier Martinez Canillas
On 1/24/22 14:52, Javier Martinez Canillas wrote: [snip] >> @@ -1898,9 +1917,13 @@ EXPORT_SYMBOL(register_framebuffer); >> void >> unregister_framebuffer(struct fb_info *fb_info) >> { >> -mutex_lock(_lock); >> +bool forced_out = fb_info->forced_out; >> + >> +if (!forced_out) >> +

Re: [PATCH 1/5] fbdev: Hot-unplug firmware fb devices on forced removal

2022-01-24 Thread Javier Martinez Canillas
Hello Thomas, Thanks for the patch. On 1/24/22 13:36, Thomas Zimmermann wrote: > Hot-unplug all firmware-framebuffer devices as part of removing > them via remove_conflicting_framebuffers() et al. Releases all > memory regions to be acquired by native drivers. > > Firmware, such as EFI, install

[PATCH 1/5] fbdev: Hot-unplug firmware fb devices on forced removal

2022-01-24 Thread Thomas Zimmermann
Hot-unplug all firmware-framebuffer devices as part of removing them via remove_conflicting_framebuffers() et al. Releases all memory regions to be acquired by native drivers. Firmware, such as EFI, install a framebuffer while posting the computer. After removing the firmware-framebuffer device