Re: [PATCH 1/8] drm/print: introduce new struct drm_device based logging macros

2019-12-17 Thread Sam Ravnborg
Hi Jani. Will you type a todo entry as requested by Daniel? > Pushed this one patch, thanks for the reviews and acks. The rest could > still use review. ;) Will take a look again later tonight. I recall from last time I looked they were fine but I just never sent anything to the ML. Sam

Re: [PATCH 1/8] drm/print: introduce new struct drm_device based logging macros

2019-12-17 Thread Jani Nikula
On Tue, 10 Dec 2019, Jani Nikula wrote: > Add new struct drm_device based logging macros modeled after the core > kernel device based logging macros. These would be preferred over the > drm printk and struct device based macros in drm code, where possible. > > We have existing drm specific struct

Re: [PATCH 1/8] drm/print: introduce new struct drm_device based logging macros

2019-12-13 Thread Jani Nikula
On Thu, 12 Dec 2019, Sam Ravnborg wrote: > Hi Jani. > > On Tue, Dec 10, 2019 at 02:30:43PM +0200, Jani Nikula wrote: >> Add new struct drm_device based logging macros modeled after the core >> kernel device based logging macros. These would be preferred over the >> drm printk and struct device

Re: [PATCH 1/8] drm/print: introduce new struct drm_device based logging macros

2019-12-12 Thread Sam Ravnborg
Hi Jani. On Tue, Dec 10, 2019 at 02:30:43PM +0200, Jani Nikula wrote: > Add new struct drm_device based logging macros modeled after the core > kernel device based logging macros. These would be preferred over the > drm printk and struct device based macros in drm code, where possible. > > We

Re: [PATCH 1/8] drm/print: introduce new struct drm_device based logging macros

2019-12-10 Thread Daniel Vetter
On Tue, Dec 10, 2019 at 02:34:33PM +0200, Jani Nikula wrote: > On Tue, 10 Dec 2019, Jani Nikula wrote: > > Add new struct drm_device based logging macros modeled after the core > > kernel device based logging macros. These would be preferred over the > > drm printk and struct device based macros

Re: [PATCH 1/8] drm/print: introduce new struct drm_device based logging macros

2019-12-10 Thread Jani Nikula
On Tue, 10 Dec 2019, Jani Nikula wrote: > Add new struct drm_device based logging macros modeled after the core > kernel device based logging macros. These would be preferred over the > drm printk and struct device based macros in drm code, where possible. As to cover letter, patches 2-8 using

[PATCH 1/8] drm/print: introduce new struct drm_device based logging macros

2019-12-10 Thread Jani Nikula
Add new struct drm_device based logging macros modeled after the core kernel device based logging macros. These would be preferred over the drm printk and struct device based macros in drm code, where possible. We have existing drm specific struct device based logging functions, but they are too