[PATCH 10/17] drm: Atomic crtc/connector updates using crtc/plane helper interfaces

2014-11-06 Thread Sean Paul
On Wed, Nov 5, 2014 at 4:44 PM, Daniel Vetter wrote: > I've applied all the other nits, replies to the more interesting bits > below. > > On Wed, Nov 05, 2014 at 01:53:48PM -0500, Sean Paul wrote: >> On Sun, Nov 02, 2014 at 02:19:23PM +0100, Daniel Vetter wrote: >> > + if (new_encoder !=

[PATCH 10/17] drm: Atomic crtc/connector updates using crtc/plane helper interfaces

2014-11-05 Thread Daniel Vetter
I've applied all the other nits, replies to the more interesting bits below. On Wed, Nov 05, 2014 at 01:53:48PM -0500, Sean Paul wrote: > On Sun, Nov 02, 2014 at 02:19:23PM +0100, Daniel Vetter wrote: > > + if (new_encoder != connector_state->best_encoder) { > > nit: If you just returned early

[PATCH 10/17] drm: Atomic crtc/connector updates using crtc/plane helper interfaces

2014-11-05 Thread Sean Paul
On Sun, Nov 02, 2014 at 02:19:23PM +0100, Daniel Vetter wrote: > So this is finally the integration of the crtc and plane helper > interfaces into the atomic helper functions. > > In the check function we now have a few steps: > > - First we update the output routing and figure out which crtcs

[PATCH 10/17] drm: Atomic crtc/connector updates using crtc/plane helper interfaces

2014-11-02 Thread Daniel Vetter
So this is finally the integration of the crtc and plane helper interfaces into the atomic helper functions. In the check function we now have a few steps: - First we update the output routing and figure out which crtcs need a full mode set. Suitable encoders are selected using ->best_encoder,