Re: [PATCH 14/44] drm/v3d: Delete v3d_dev->pdev

2020-04-08 Thread Daniel Vetter
On Wed, Apr 08, 2020 at 09:27:01AM +0200, Sam Ravnborg wrote: > Hi Daniel. > > On Fri, Apr 03, 2020 at 03:57:58PM +0200, Daniel Vetter wrote: > > We already have it in v3d_dev->drm.dev with zero additional pointer > > chasing. Personally I don't like duplicated pointers like this > > because: > >

Re: [PATCH 14/44] drm/v3d: Delete v3d_dev->pdev

2020-04-08 Thread Sam Ravnborg
Hi Daniel. On Fri, Apr 03, 2020 at 03:57:58PM +0200, Daniel Vetter wrote: > We already have it in v3d_dev->drm.dev with zero additional pointer > chasing. Personally I don't like duplicated pointers like this > because: > - reviewers need to check whether the pointer is for the same or > different

Re: [PATCH 14/44] drm/v3d: Delete v3d_dev->pdev

2020-04-03 Thread Eric Anholt
On Fri, Apr 3, 2020 at 6:58 AM Daniel Vetter wrote: > > We already have it in v3d_dev->drm.dev with zero additional pointer > chasing. Personally I don't like duplicated pointers like this > because: > - reviewers need to check whether the pointer is for the same or > different objects if there's

[PATCH 14/44] drm/v3d: Delete v3d_dev->pdev

2020-04-03 Thread Daniel Vetter
We already have it in v3d_dev->drm.dev with zero additional pointer chasing. Personally I don't like duplicated pointers like this because: - reviewers need to check whether the pointer is for the same or different objects if there's multiple - compilers have an easier time too To avoid having to