Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio

2022-05-05 Thread Arnd Bergmann
On Thu, May 5, 2022 at 5:04 PM Mark Brown wrote: > On Thu, May 05, 2022 at 04:59:35PM +0200, Arnd Bergmann wrote: > > On Thu, May 5, 2022 at 4:39 PM Mark Brown wrote: > > > On Thu, May 05, 2022 at 04:33:06PM +0200, Linus Walleij wrote: > > > > On Thu, May 5, 2022 at 8:04 AM Arnd Bergmann wrote:

Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio

2022-05-05 Thread Mark Brown
On Thu, May 05, 2022 at 04:59:35PM +0200, Arnd Bergmann wrote: > On Thu, May 5, 2022 at 4:39 PM Mark Brown wrote: > > On Thu, May 05, 2022 at 04:33:06PM +0200, Linus Walleij wrote: > > > On Thu, May 5, 2022 at 8:04 AM Arnd Bergmann wrote: > > > > static struct snd_soc_jack_pin hs_jack_pin[] = {

Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio

2022-05-05 Thread Arnd Bergmann
On Thu, May 5, 2022 at 4:39 PM Mark Brown wrote: > On Thu, May 05, 2022 at 04:33:06PM +0200, Linus Walleij wrote: > > On Thu, May 5, 2022 at 8:04 AM Arnd Bergmann wrote: > > > > /* Headphones jack detection DAPM pin */ > > > static struct snd_soc_jack_pin hs_jack_pin[] = { > > > { > > >

Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio

2022-05-05 Thread Mark Brown
On Thu, May 05, 2022 at 04:33:06PM +0200, Linus Walleij wrote: > On Thu, May 5, 2022 at 8:04 AM Arnd Bergmann wrote: > > /* Headphones jack detection DAPM pin */ > > static struct snd_soc_jack_pin hs_jack_pin[] = { > > { > > .pin= "Headphone Jack", > >

Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio

2022-05-05 Thread Linus Walleij
On Thu, May 5, 2022 at 8:04 AM Arnd Bergmann wrote: > On Wed, May 4, 2022 at 11:59 PM Linus Walleij > wrote: > > Thus drop one ! in front of the expression, just > > !SND_SOC_DAPM_EVENT_ON(event) > > Ok, done. But I still leave the extra 'invert=1' in hs_jack_pin[], right? > > /* Headphones ja

Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio

2022-05-04 Thread Arnd Bergmann
On Wed, May 4, 2022 at 11:59 PM Linus Walleij wrote: > On Mon, May 2, 2022 at 9:08 AM Arnd Bergmann wrote: > > On Sun, May 1, 2022 at 11:41 PM Linus Walleij > > wrote: > > > > > > (...) > > > > +static struct gpiod_lookup_table hx4700_audio_gpio_table = { > > > > + .dev_id = "hx4700-audio

Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio

2022-05-04 Thread Linus Walleij
On Mon, May 2, 2022 at 9:08 AM Arnd Bergmann wrote: > On Sun, May 1, 2022 at 11:41 PM Linus Walleij > wrote: > > > > (...) > > > +static struct gpiod_lookup_table hx4700_audio_gpio_table = { > > > + .dev_id = "hx4700-audio", > > > + .table = { > > > + GPIO_LOOKUP("gpio-

Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio

2022-05-02 Thread Arnd Bergmann
On Sun, May 1, 2022 at 11:41 PM Linus Walleij wrote: > > (...) > > +static struct gpiod_lookup_table hx4700_audio_gpio_table = { > > + .dev_id = "hx4700-audio", > > + .table = { > > + GPIO_LOOKUP("gpio-pxa", GPIO75_HX4700_EARPHONE_nDET, > > + "ea

Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio

2022-05-01 Thread Linus Walleij
On Tue, Apr 19, 2022 at 6:41 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > The audio driver should not use a hardwired gpio number > from the header. Change it to use a lookup table. > > Cc: Philipp Zabel > Cc: Paul Parsons > Acked-by: Mark Brown > Acked-by: Robert Jarzmik > Cc: alsa-de.

[PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio

2022-04-19 Thread Arnd Bergmann
From: Arnd Bergmann The audio driver should not use a hardwired gpio number from the header. Change it to use a lookup table. Cc: Philipp Zabel Cc: Paul Parsons Acked-by: Mark Brown Acked-by: Robert Jarzmik Cc: alsa-de...@alsa-project.org Signed-off-by: Arnd Bergmann --- arch/arm/mach-pxa/