Re: [PATCH 19/37] drm/fsl: Drop drm_vblank_cleanup

2017-06-08 Thread Stefan Agner
On 2017-05-31 01:52, Daniel Vetter wrote: > On Tue, May 30, 2017 at 02:17:04PM -0700, Stefan Agner wrote: >> On 2017-05-26 00:00, Daniel Vetter wrote: >> > On Thu, May 25, 2017 at 10:18 AM, Stefan Agner wrote: >> >> On 2017-05-24 07:51, Daniel Vetter wrote: >> >>> Again cleanup

Re: [PATCH 19/37] drm/fsl: Drop drm_vblank_cleanup

2017-05-31 Thread Daniel Vetter
On Tue, May 30, 2017 at 02:17:04PM -0700, Stefan Agner wrote: > On 2017-05-26 00:00, Daniel Vetter wrote: > > On Thu, May 25, 2017 at 10:18 AM, Stefan Agner wrote: > >> On 2017-05-24 07:51, Daniel Vetter wrote: > >>> Again cleanup before irq disabling doesn't really stop the

Re: [PATCH 19/37] drm/fsl: Drop drm_vblank_cleanup

2017-05-30 Thread Stefan Agner
On 2017-05-26 00:00, Daniel Vetter wrote: > On Thu, May 25, 2017 at 10:18 AM, Stefan Agner wrote: >> On 2017-05-24 07:51, Daniel Vetter wrote: >>> Again cleanup before irq disabling doesn't really stop the races, >>> so just drop it. Proper fix would be to put

Re: [PATCH 19/37] drm/fsl: Drop drm_vblank_cleanup

2017-05-26 Thread Daniel Vetter
On Thu, May 25, 2017 at 10:18 AM, Stefan Agner wrote: > On 2017-05-24 07:51, Daniel Vetter wrote: >> Again cleanup before irq disabling doesn't really stop the races, >> so just drop it. Proper fix would be to put drm_atomic_helper_shutdown >> before everything gets cleaned up. >

Re: [PATCH 19/37] drm/fsl: Drop drm_vblank_cleanup

2017-05-25 Thread Stefan Agner
On 2017-05-24 07:51, Daniel Vetter wrote: > Again cleanup before irq disabling doesn't really stop the races, > so just drop it. Proper fix would be to put drm_atomic_helper_shutdown > before everything gets cleaned up. Hm, I already use the non-atomic drm_crtc_force_disable_all before, I think

[PATCH 19/37] drm/fsl: Drop drm_vblank_cleanup

2017-05-24 Thread Daniel Vetter
Again cleanup before irq disabling doesn't really stop the races, so just drop it. Proper fix would be to put drm_atomic_helper_shutdown before everything gets cleaned up. Cc: Stefan Agner Signed-off-by: Daniel Vetter ---