[PATCH 2/2] drm/dp/mst: always send reply for UP request

2015-12-30 Thread Dave Airlie
> > 1. As UP replies also got to slots (even as mentioned in code it > should not happen), we should clean them somewhere. For DOWN requests they > are cleaned on DOWN reply when full reply received. However we will not > receive interrupt when UP reply sent; > > 2. I am not sure if

[PATCH 2/2] drm/dp/mst: always send reply for UP request

2015-12-21 Thread Lysenko, Mykola
sense or I misunderstood code somewhere. Mykola From: Wentland, Harry Sent: Sunday, December 20, 2015 12:21 AM To: airlied at gmail.com; Lysenko, Mykola Cc: dri-devel at lists.freedesktop.org Subject: Re: [PATCH 2/2] drm/dp/mst: always send reply for UP request Thanks, Dave. Do you have

[PATCH 2/2] drm/dp/mst: always send reply for UP request

2015-12-19 Thread Wentland, Harry
Thanks, Dave. Do you have an example when the up reply would be too big to fit into one sideband message? We don't expect that to happen. Mykola, can you see if Dave's patch is a good alternative to your patch? Harry On Fri, Dec 18, 2015 at 7:57 PM -0800, "Dave Airlie" mailto:airlied at

[PATCH 2/2] drm/dp/mst: always send reply for UP request

2015-12-19 Thread Dave Airlie
On 19 December 2015 at 08:14, Harry Wentland wrote: > From: Mykola Lysenko > > We should always send reply for UP request in order > to make downstream device clean-up resources appropriately. > > Issue was that reply for UP request was sent only once. What happens though if the up reply is too

[PATCH 2/2] drm/dp/mst: always send reply for UP request

2015-12-18 Thread Harry Wentland
From: Mykola Lysenko We should always send reply for UP request in order to make downstream device clean-up resources appropriately. Issue was that reply for UP request was sent only once. Signed-off-by: Mykola Lysenko --- drivers/gpu/drm/drm_dp_mst_topology.c | 30