Hi,
On 26 August 2016 at 10:28, Rob Clark wrote:
> On Thu, Aug 25, 2016 at 9:48 PM, Xinliang Liu
> wrote:
>> On 17 August 2016 at 19:11, Daniel Vetter wrote:
>>> On Wed, Aug 17, 2016 at 07:02:01PM +0800, Xinliang Liu wrote:
Hi,
On 17 August 2016 at 18:17, Daniel Vetter
On 17 August 2016 at 19:11, Daniel Vetter wrote:
> On Wed, Aug 17, 2016 at 07:02:01PM +0800, Xinliang Liu wrote:
>> Hi,
>>
>> On 17 August 2016 at 18:17, Daniel Vetter wrote:
>> > I just broke the build :(
>> >
>> > Note that the cleanup function is a bit confused: ade_data was never
>> > set as
On Thu, Aug 25, 2016 at 9:48 PM, Xinliang Liu
wrote:
> On 17 August 2016 at 19:11, Daniel Vetter wrote:
>> On Wed, Aug 17, 2016 at 07:02:01PM +0800, Xinliang Liu wrote:
>>> Hi,
>>>
>>> On 17 August 2016 at 18:17, Daniel Vetter wrote:
>>> > I just broke the build :(
>>> >
>>> > Note that the
Hi,
On 17 August 2016 at 18:17, Daniel Vetter wrote:
> I just broke the build :(
>
> Note that the cleanup function is a bit confused: ade_data was never
> set as drvdata, and calling drm_crtc_cleanup directly is a bug - this
Yes, this is a bug. Thanks for pointing out this.
> is called
On Wed, Aug 17, 2016 at 07:02:01PM +0800, Xinliang Liu wrote:
> Hi,
>
> On 17 August 2016 at 18:17, Daniel Vetter wrote:
> > I just broke the build :(
> >
> > Note that the cleanup function is a bit confused: ade_data was never
> > set as drvdata, and calling drm_crtc_cleanup directly is a bug -
I just broke the build :(
Note that the cleanup function is a bit confused: ade_data was never
set as drvdata, and calling drm_crtc_cleanup directly is a bug - this
is called indirectly through drm_mode_config_cleanup, which calls into
crtc->destroy, which already has the call to