Re: [PATCH 2/2] drm: test: Fix 32-bit issue in drm_buddy_test

2023-03-29 Thread Christian König
Am 29.03.23 um 13:28 schrieb Jani Nikula: On Wed, 29 Mar 2023, Maíra Canal wrote: On 3/29/23 03:55, David Gow wrote: The drm_buddy_test KUnit tests verify that returned blocks have sizes which are powers of two using is_power_of_2(). However, is_power_of_2() operations on a 'long', but the blo

Re: [PATCH 2/2] drm: test: Fix 32-bit issue in drm_buddy_test

2023-03-29 Thread Jani Nikula
On Wed, 29 Mar 2023, Maíra Canal wrote: > On 3/29/23 03:55, David Gow wrote: >> The drm_buddy_test KUnit tests verify that returned blocks have sizes >> which are powers of two using is_power_of_2(). However, is_power_of_2() >> operations on a 'long', but the block size is a u64. So on systems whe

Re: [PATCH 2/2] drm: test: Fix 32-bit issue in drm_buddy_test

2023-03-29 Thread Maíra Canal
On 3/29/23 03:55, David Gow wrote: The drm_buddy_test KUnit tests verify that returned blocks have sizes which are powers of two using is_power_of_2(). However, is_power_of_2() operations on a 'long', but the block size is a u64. So on systems where long is 32-bit, this can sometimes fail even on

Re: [PATCH 2/2] drm: test: Fix 32-bit issue in drm_buddy_test

2023-03-29 Thread Jani Nikula
On Wed, 29 Mar 2023, Jani Nikula wrote: > On Wed, 29 Mar 2023, David Gow wrote: >> The drm_buddy_test KUnit tests verify that returned blocks have sizes >> which are powers of two using is_power_of_2(). However, is_power_of_2() >> operations on a 'long', but the block size is a u64. So on systems

Re: [PATCH 2/2] drm: test: Fix 32-bit issue in drm_buddy_test

2023-03-29 Thread Jani Nikula
On Wed, 29 Mar 2023, David Gow wrote: > The drm_buddy_test KUnit tests verify that returned blocks have sizes > which are powers of two using is_power_of_2(). However, is_power_of_2() > operations on a 'long', but the block size is a u64. So on systems where > long is 32-bit, this can sometimes fa

[PATCH 2/2] drm: test: Fix 32-bit issue in drm_buddy_test

2023-03-28 Thread David Gow
The drm_buddy_test KUnit tests verify that returned blocks have sizes which are powers of two using is_power_of_2(). However, is_power_of_2() operations on a 'long', but the block size is a u64. So on systems where long is 32-bit, this can sometimes fail even on correctly sized blocks. This only r