Re: [PATCH 2/2] mm/hmm: Only set FAULT_FLAG_ALLOW_RETRY for non-blocking

2019-05-14 Thread Alex Deucher
PM > > *To:* Jerome Glisse > > *Cc:* linux...@kvack.org; airl...@gmail.com; > > amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > > alex.deuc...@amd.com > > *Subject:* Re: [PATCH 2/2] mm/hmm: Only set FAULT_FLAG_ALLOW_RETRY for > > non-blo

Re: [PATCH 2/2] mm/hmm: Only set FAULT_FLAG_ALLOW_RETRY for non-blocking

2019-05-14 Thread Kuehling, Felix
-gfx on behalf of > Kuehling, Felix > *Sent:* Monday, May 13, 2019 3:36 PM > *To:* Jerome Glisse > *Cc:* linux...@kvack.org; airl...@gmail.com; > amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > alex.deuc...@amd.com > *Subject:* Re: [PATCH 2/2] mm/

Re: [PATCH 2/2] mm/hmm: Only set FAULT_FLAG_ALLOW_RETRY for non-blocking

2019-05-13 Thread Kuehling, Felix
[Fixed Alex's email address, sorry for getting it wrong first] On 2019-05-13 3:49 p.m., Jerome Glisse wrote: > [CAUTION: External Email] > > Andrew can we get this 2 fixes line up for 5.2 ? > > On Mon, May 13, 2019 at 07:36:44PM +, Kuehling, Felix wrote: >> Hi Jerome, >> >> Do you want me to p

Re: [PATCH 2/2] mm/hmm: Only set FAULT_FLAG_ALLOW_RETRY for non-blocking

2019-05-13 Thread Deucher, Alexander
Alex From: amd-gfx on behalf of Kuehling, Felix Sent: Monday, May 13, 2019 3:36 PM To: Jerome Glisse Cc: linux...@kvack.org; airl...@gmail.com; amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; alex.deuc...@amd.com Subject: Re: [PATCH 2/2] mm/hmm: Only set FAULT_FLAG_ALLOW_RETRY

Re: [PATCH 2/2] mm/hmm: Only set FAULT_FLAG_ALLOW_RETRY for non-blocking

2019-05-13 Thread Jerome Glisse
Andrew can we get this 2 fixes line up for 5.2 ? On Mon, May 13, 2019 at 07:36:44PM +, Kuehling, Felix wrote: > Hi Jerome, > > Do you want me to push the patches to your branch? Or are you going to > apply them yourself? > > Is your hmm-5.2-v3 branch going to make it into Linux 5.2? If so,

Re: [PATCH 2/2] mm/hmm: Only set FAULT_FLAG_ALLOW_RETRY for non-blocking

2019-05-13 Thread Kuehling, Felix
Hi Jerome, Do you want me to push the patches to your branch? Or are you going to apply them yourself? Is your hmm-5.2-v3 branch going to make it into Linux 5.2? If so, do you know when? I'd like to coordinate with Dave Airlie so that we can also get that update into a drm-next branch soon. I

Re: [PATCH 2/2] mm/hmm: Only set FAULT_FLAG_ALLOW_RETRY for non-blocking

2019-05-10 Thread Jerome Glisse
On Fri, May 10, 2019 at 07:53:24PM +, Kuehling, Felix wrote: > Don't set this flag by default in hmm_vma_do_fault. It is set > conditionally just a few lines below. Setting it unconditionally > can lead to handle_mm_fault doing a non-blocking fault, returning > -EBUSY and unlocking mmap_sem une

[PATCH 2/2] mm/hmm: Only set FAULT_FLAG_ALLOW_RETRY for non-blocking

2019-05-10 Thread Kuehling, Felix
Don't set this flag by default in hmm_vma_do_fault. It is set conditionally just a few lines below. Setting it unconditionally can lead to handle_mm_fault doing a non-blocking fault, returning -EBUSY and unlocking mmap_sem unexpectedly. Signed-off-by: Felix Kuehling --- mm/hmm.c | 2 +- 1 file c