Re: [PATCH 2/3] drm/radeon: Inline drm_get_pci_dev

2020-02-25 Thread Alex Deucher
On Sat, Feb 22, 2020 at 12:54 PM Daniel Vetter wrote: > > It's the last user, and more importantly, it's the last non-legacy > user of anything in drm_pci.c. > > The only tricky bit is the agp initialization. But a close look shows > that radeon does not use the drm_agp midlayer (the main use of

Re: [PATCH 2/3] drm/radeon: Inline drm_get_pci_dev

2020-02-24 Thread Daniel Vetter
On Mon, Feb 24, 2020 at 9:46 PM Daniel Vetter wrote: > > On Mon, Feb 24, 2020 at 5:31 PM Emil Velikov wrote: > > > > On Sat, 22 Feb 2020 at 17:54, Daniel Vetter wrote: > > > > > > It's the last user, and more importantly, it's the last non-legacy > > > user of anything in drm_pci.c. > > > > > >

Re: [PATCH 2/3] drm/radeon: Inline drm_get_pci_dev

2020-02-24 Thread Daniel Vetter
On Mon, Feb 24, 2020 at 5:31 PM Emil Velikov wrote: > > On Sat, 22 Feb 2020 at 17:54, Daniel Vetter wrote: > > > > It's the last user, and more importantly, it's the last non-legacy > > user of anything in drm_pci.c. > > > > The only tricky bit is the agp initialization. But a close look shows >

Re: [PATCH 2/3] drm/radeon: Inline drm_get_pci_dev

2020-02-24 Thread Emil Velikov
On Sat, 22 Feb 2020 at 17:54, Daniel Vetter wrote: > > It's the last user, and more importantly, it's the last non-legacy > user of anything in drm_pci.c. > > The only tricky bit is the agp initialization. But a close look shows > that radeon does not use the drm_agp midlayer (the main use of

[PATCH 2/3] drm/radeon: Inline drm_get_pci_dev

2020-02-22 Thread Daniel Vetter
It's the last user, and more importantly, it's the last non-legacy user of anything in drm_pci.c. The only tricky bit is the agp initialization. But a close look shows that radeon does not use the drm_agp midlayer (the main use of that is drm_bufs for legacy drivers), and instead could use the