Re: [PATCH 2/3] drm: rcar-du: Write ESCR register per channel

2018-08-30 Thread Kieran Bingham
Hi Jacopo, On 30/08/18 17:00, Kieran Bingham wrote: > Hi Jacopo, > > On 22/08/18 08:21, Jacopo Mondi wrote: >> The ESCR registers offset definition is confusing, as each channel is >> equipped with an ESCR register instance, but the names suggest only ESCR and >> ESCR2 are taken into account. >>

Re: [PATCH 2/3] drm: rcar-du: Write ESCR register per channel

2018-08-30 Thread Kieran Bingham
Hi Jacopo, On 22/08/18 08:21, Jacopo Mondi wrote: > The ESCR registers offset definition is confusing, as each channel is > equipped with an ESCR register instance, but the names suggest only ESCR and > ESCR2 are taken into account. > > Rename the offsets to a name that includes the channels

[PATCH 2/3] drm: rcar-du: Write ESCR register per channel

2018-08-23 Thread Jacopo Mondi
The ESCR registers offset definition is confusing, as each channel is equipped with an ESCR register instance, but the names suggest only ESCR and ESCR2 are taken into account. Rename the offsets to a name that includes the channels they apply to, and write them to each channel with

Re: [PATCH 2/3] drm: rcar-du: Write ESCR register per channel

2018-08-22 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Wednesday, 22 August 2018 10:21:48 EEST Jacopo Mondi wrote: > The ESCR registers offset definition is confusing, as each channel is > equipped with an ESCR register instance, but the names suggest only ESCR and > ESCR2 are taken into account. > > Rename