Re: [PATCH 2/7] drm/ttm: use an operation ctx for ttm_mem_global_alloc

2018-01-25 Thread Christian König
Unfortunately the patches are already comitted (with a better commit message IIRC). But the variable name sounds just like a style nit pick to me we can fix in a separate patch as well. Thanks, Christian. Am 25.01.2018 um 00:24 schrieb Sinclair Yeh: Hi, Sorry, I've been on a leave. Catchi

Re: [PATCH 2/7] drm/ttm: use an operation ctx for ttm_mem_global_alloc

2018-01-24 Thread Sinclair Yeh
Hi, Sorry, I've been on a leave. Catching up on emails. In case this is still not yet merged, my comment is be consist with the new variable name. In some cases it's "ttm_opt_ctx", in others it's "ctx". I prefer ttm_opt_ctx because it's more descriptive. And yes, some description on why this

Re: [PATCH 2/7] drm/ttm: use an operation ctx for ttm_mem_global_alloc

2017-12-21 Thread Thomas Hellstrom
With a suitable commit log, LGTM. Reviewed-by: Thomas Hellstrom On 12/20/2017 11:34 AM, Roger He wrote: Change-Id: I5279b5cd3560c4082b00f822219575a5f9c3808a Signed-off-by: Roger He --- drivers/gpu/drm/ttm/ttm_bo.c| 2 +- drivers/gpu/drm/ttm/ttm_memory.c

Re: [PATCH 2/7] drm/ttm: use an operation ctx for ttm_mem_global_alloc

2017-12-20 Thread Christian König
Commit message needed! Something like: Forward the operation context to ttm_mem_global_alloc as well. Am 20.12.2017 um 11:34 schrieb Roger He: Change-Id: I5279b5cd3560c4082b00f822219575a5f9c3808a Signed-off-by: Roger He With the commit message fixed, patch is Reviewed-by: Christian König .

[PATCH 2/7] drm/ttm: use an operation ctx for ttm_mem_global_alloc

2017-12-20 Thread Roger He
Change-Id: I5279b5cd3560c4082b00f822219575a5f9c3808a Signed-off-by: Roger He --- drivers/gpu/drm/ttm/ttm_bo.c| 2 +- drivers/gpu/drm/ttm/ttm_memory.c| 15 +-- drivers/gpu/drm/ttm/ttm_object.c| 13 ++--- drivers/gpu/drm/vmwgf