Re: [Intel-gfx] [PATCH 22/24] drm: Nerf the preclose callback for modern drivers

2017-03-14 Thread Daniel Vetter
On Mon, Mar 13, 2017 at 03:29:20PM -0400, Sean Paul wrote: > On Wed, Mar 08, 2017 at 03:12:55PM +0100, Daniel Vetter wrote: > > With all drivers converted there's only legacy dri1 drivers using it. > > Not going to touch those, instead just hide it like we've done with > > other dri1 driver hooks l

Re: [Intel-gfx] [PATCH 22/24] drm: Nerf the preclose callback for modern drivers

2017-03-13 Thread Sean Paul
On Wed, Mar 08, 2017 at 03:12:55PM +0100, Daniel Vetter wrote: > With all drivers converted there's only legacy dri1 drivers using it. > Not going to touch those, instead just hide it like we've done with > other dri1 driver hooks like firstopen. > > In all this I didn't find any real reason why w

Re: [PATCH 22/24] drm: Nerf the preclose callback for modern drivers

2017-03-09 Thread Daniel Vetter
On Wed, Mar 08, 2017 at 03:12:55PM +0100, Daniel Vetter wrote: > With all drivers converted there's only legacy dri1 drivers using it. > Not going to touch those, instead just hide it like we've done with > other dri1 driver hooks like firstopen. > > In all this I didn't find any real reason why w

[PATCH 22/24] drm: Nerf the preclose callback for modern drivers

2017-03-08 Thread Daniel Vetter
With all drivers converted there's only legacy dri1 drivers using it. Not going to touch those, instead just hide it like we've done with other dri1 driver hooks like firstopen. In all this I didn't find any real reason why we'd needed 2 hooks, and having symmetry between open and close just appea