[PATCH 22/29] drm/omap: Move DISPC timing checks to CRTC .mode_valid() operation

2018-12-05 Thread Laurent Pinchart
The DISPC timings checks relate to the CRTC, but they're performed in the encoder and connector .atomic_check() and .mode_valid() operations. Move them to the CRTC .mode_valid() operation. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/omap_connector.c | 6 -- drivers/gpu/drm/om

Re: [PATCH 22/29] drm/omap: Move DISPC timing checks to CRTC .mode_valid() operation

2019-02-11 Thread Sebastian Reichel
Hi, ping & actually add the cc :) -- Sebastian On Tue, Dec 11, 2018 at 10:06:07AM +0200, Laurent Pinchart wrote: >> The problem is, that DISPC timings for DSI are not directly >> calculated from mode. Instead DSI code does some modifications >> before applying the DISPC settings. > > I wonder w

Re: [PATCH 22/29] drm/omap: Move DISPC timing checks to CRTC .mode_valid() operation

2018-12-09 Thread Laurent Pinchart
Hi Sebastian, On Monday, 10 December 2018 00:07:55 EET Sebastian Reichel wrote: > On Wed, Dec 05, 2018 at 05:00:15PM +0200, Laurent Pinchart wrote: > > The DISPC timings checks relate to the CRTC, but they're performed in > > the encoder and connector .atomic_check() and .mode_valid() operations.

Re: [PATCH 22/29] drm/omap: Move DISPC timing checks to CRTC .mode_valid() operation

2018-12-10 Thread Sebastian Reichel
Hi, On Wed, Dec 05, 2018 at 05:00:15PM +0200, Laurent Pinchart wrote: > The DISPC timings checks relate to the CRTC, but they're performed in > the encoder and connector .atomic_check() and .mode_valid() operations. > Move them to the CRTC .mode_valid() operation. > > Signed-off-by: Laurent Pinch

Re: [PATCH 22/29] drm/omap: Move DISPC timing checks to CRTC .mode_valid() operation

2018-12-11 Thread Laurent Pinchart
Hi Sebastian, (CC'ing Daniel) On Tuesday, 11 December 2018 03:07:45 EET Sebastian Reichel wrote: > On Mon, Dec 10, 2018 at 02:14:01PM +0100, Sebastian Reichel wrote: > > On Mon, Dec 10, 2018 at 09:50:08AM +0200, Laurent Pinchart wrote: > >> On Monday, 10 December 2018 00:07:55 EET Sebastian Reich

Re: [PATCH 22/29] drm/omap: Move DISPC timing checks to CRTC .mode_valid() operation

2018-12-11 Thread Sebastian Reichel
Hi, On Mon, Dec 10, 2018 at 09:50:08AM +0200, Laurent Pinchart wrote: > Hi Sebastian, > > On Monday, 10 December 2018 00:07:55 EET Sebastian Reichel wrote: > > On Wed, Dec 05, 2018 at 05:00:15PM +0200, Laurent Pinchart wrote: > > > The DISPC timings checks relate to the CRTC, but they're performe

Re: [PATCH 22/29] drm/omap: Move DISPC timing checks to CRTC .mode_valid() operation

2018-12-11 Thread Sebastian Reichel
Hi, On Mon, Dec 10, 2018 at 02:14:01PM +0100, Sebastian Reichel wrote: > On Mon, Dec 10, 2018 at 09:50:08AM +0200, Laurent Pinchart wrote: > > Hi Sebastian, > > > > On Monday, 10 December 2018 00:07:55 EET Sebastian Reichel wrote: > > > On Wed, Dec 05, 2018 at 05:00:15PM +0200, Laurent Pinchart w