Re: [PATCH 28/30] fbdev/core: Move file-I/O code into separate file

2023-06-12 Thread Thomas Zimmermann
Hi Am 07.06.23 um 22:48 schrieb Sam Ravnborg: Hi Thomas. On Mon, Jun 05, 2023 at 04:48:10PM +0200, Thomas Zimmermann wrote: Move fbdev's file-I/O code into a separate file and contain it in init and cleanup helpers. No functional changes. Signed-off-by: Thomas Zimmermann Consider moving the

Re: [PATCH 28/30] fbdev/core: Move file-I/O code into separate file

2023-06-07 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Move fbdev's file-I/O code into a separate file and contain it in > init and cleanup helpers. No functional changes. > > Signed-off-by: Thomas Zimmermann > --- [...] > + > +#include #include here, the robot complained about: drivers/video/fbdev/core/fb_devfs.

Re: [PATCH 28/30] fbdev/core: Move file-I/O code into separate file

2023-06-07 Thread Sam Ravnborg
Hi Thomas. On Mon, Jun 05, 2023 at 04:48:10PM +0200, Thomas Zimmermann wrote: > Move fbdev's file-I/O code into a separate file and contain it in > init and cleanup helpers. No functional changes. > > Signed-off-by: Thomas Zimmermann Consider moving the two helps as noted below. With or without

Re: [PATCH 28/30] fbdev/core: Move file-I/O code into separate file

2023-06-05 Thread kernel test robot
-lkp/linux/commits/Thomas-Zimmermann/backlight-bd6107-Compare-against-struct-fb_info-device/20230605-225002 base: next-20230605 patch link: https://lore.kernel.org/r/20230605144812.15241-29-tzimmermann%40suse.de patch subject: [PATCH 28/30] fbdev/core: Move file-I/O code into separate file con

[PATCH 28/30] fbdev/core: Move file-I/O code into separate file

2023-06-05 Thread Thomas Zimmermann
Move fbdev's file-I/O code into a separate file and contain it in init and cleanup helpers. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/core/Makefile | 1 + drivers/video/fbdev/core/fb_devfs.c| 484 + drivers/video/fbdev/core