Re: [PATCH 28/51] DMA-API: sound: fix dma mask handling in a lot of drivers

2013-09-26 Thread Russell King - ARM Linux
On Thu, Sep 26, 2013 at 09:51:23AM +0200, Takashi Iwai wrote: Hi, sorry for the lat response, as I've been traveling in the last weeks. At Thu, 19 Sep 2013 22:53:02 +0100, Russell King wrote: This code sequence is unsafe in modules: static u64 mask = DMA_BIT_MASK(something);

[PATCH 28/51] DMA-API: sound: fix dma mask handling in a lot of drivers

2013-09-23 Thread Russell King
This code sequence is unsafe in modules: static u64 mask = DMA_BIT_MASK(something); ... if (!dev-dma_mask) dev-dma_mask = mask; as if a module is reloaded, the mask will be pointing at the original module's mask address, and this can lead to oopses. Moreover, they all

Re: [PATCH 28/51] DMA-API: sound: fix dma mask handling in a lot of drivers

2013-09-23 Thread Mark Brown
On Thu, Sep 19, 2013 at 10:53:02PM +0100, Russell King wrote: This code sequence is unsafe in modules: static u64 mask = DMA_BIT_MASK(something); ... if (!dev-dma_mask) dev-dma_mask = mask; Acked-by: Mark Brown broo...@linaro.org signature.asc Description: Digital