Re: [PATCH 3/3] [v2] drm/xe/xe2: fix 64-bit division in pte_update_size

2024-02-28 Thread Lucas De Marchi
On Wed, Feb 28, 2024 at 01:26:29PM +0100, Arnd Bergmann wrote: On Mon, Feb 26, 2024, at 17:40, Lucas De Marchi wrote: On Mon, Feb 26, 2024 at 01:46:38PM +0100, Arnd Bergmann wrote: Fixes: 237412e45390 ("drm/xe: Enable 32bits build") Signed-off-by: Arnd Bergmann --- v2: use correct Fixes tag

Re: [PATCH 3/3] [v2] drm/xe/xe2: fix 64-bit division in pte_update_size

2024-02-28 Thread Arnd Bergmann
On Mon, Feb 26, 2024, at 17:40, Lucas De Marchi wrote: > On Mon, Feb 26, 2024 at 01:46:38PM +0100, Arnd Bergmann wrote: >> >>Fixes: 237412e45390 ("drm/xe: Enable 32bits build") >>Signed-off-by: Arnd Bergmann >>--- >>v2: use correct Fixes tag > > but what about the other comment? How are we

Re: [PATCH 3/3] [v2] drm/xe/xe2: fix 64-bit division in pte_update_size

2024-02-26 Thread Lucas De Marchi
On Mon, Feb 26, 2024 at 01:46:38PM +0100, Arnd Bergmann wrote: From: Arnd Bergmann This function does not build on 32-bit targets when the compiler fails to reduce DIV_ROUND_UP() into a shift: ld.lld: error: undefined symbol: __aeabi_uldivmod referenced by xe_migrate.c

[PATCH 3/3] [v2] drm/xe/xe2: fix 64-bit division in pte_update_size

2024-02-26 Thread Arnd Bergmann
From: Arnd Bergmann This function does not build on 32-bit targets when the compiler fails to reduce DIV_ROUND_UP() into a shift: ld.lld: error: undefined symbol: __aeabi_uldivmod >>> referenced by xe_migrate.c >>> drivers/gpu/drm/xe/xe_migrate.o:(pte_update_size) in archive >>>