Re: [PATCH 3/3] drm/bridge: ps8640: Rework power state handling

2020-08-22 Thread Sam Ravnborg
Hi Enric. On Fri, Aug 21, 2020 at 01:38:09PM +0200, Sam Ravnborg wrote: > Hi Enric. > > > > > Let me reformulate the question for if it was not clear. > > > > What I did is be able to read the EDID every time userspace asks for it (so > > kernel enables all the required) and Sam is proposing

Re: [PATCH 3/3] drm/bridge: ps8640: Rework power state handling

2020-08-22 Thread Sam Ravnborg
On Mon, Jun 15, 2020 at 10:53:20PM +0200, Enric Balletbo i Serra wrote: > The get_edid() callback can be triggered anytime by an ioctl, i.e > > drm_mode_getconnector (ioctl) > -> drm_helper_probe_single_connector_modes >-> drm_bridge_connector_get_modes > ->

Re: [PATCH 3/3] drm/bridge: ps8640: Rework power state handling

2020-08-22 Thread Enric Balletbo i Serra
Dear drm_bridge maintainers, It's been a while since I send these patches, and I'd like to find a proper solution. On 25/6/20 11:21, Enric Balletbo i Serra wrote: > Hi Sam, > > On 24/6/20 9:07, Sam Ravnborg wrote: >> Hi Enric. >> >> On Tue, Jun 23, 2020 at 05:16:43PM +0200, Enric Balletbo i

Re: [PATCH 3/3] drm/bridge: ps8640: Rework power state handling

2020-08-21 Thread Sam Ravnborg
Hi Enric. > > Let me reformulate the question for if it was not clear. > > What I did is be able to read the EDID every time userspace asks for it (so > kernel enables all the required) and Sam is proposing to just fail if all is > not > setup. I can obviously do this but my question is, at

Re: [PATCH 3/3] drm/bridge: ps8640: Rework power state handling

2020-06-26 Thread Enric Balletbo i Serra
Hi Sam, On 24/6/20 9:07, Sam Ravnborg wrote: > Hi Enric. > > On Tue, Jun 23, 2020 at 05:16:43PM +0200, Enric Balletbo i Serra wrote: >> Hi Sam, >> >> Many thanks for your feedback. See my answers below. >> >> On 20/6/20 23:42, Sam Ravnborg wrote: >>> Hi Enric. >>> >>> On Mon, Jun 15, 2020 at

Re: [PATCH 3/3] drm/bridge: ps8640: Rework power state handling

2020-06-24 Thread Sam Ravnborg
Hi Enric. On Tue, Jun 23, 2020 at 05:16:43PM +0200, Enric Balletbo i Serra wrote: > Hi Sam, > > Many thanks for your feedback. See my answers below. > > On 20/6/20 23:42, Sam Ravnborg wrote: > > Hi Enric. > > > > On Mon, Jun 15, 2020 at 10:53:20PM +0200, Enric Balletbo i Serra wrote: > >> The

Re: [PATCH 3/3] drm/bridge: ps8640: Rework power state handling

2020-06-24 Thread Enric Balletbo i Serra
Hi Sam, Many thanks for your feedback. See my answers below. On 20/6/20 23:42, Sam Ravnborg wrote: > Hi Enric. > > On Mon, Jun 15, 2020 at 10:53:20PM +0200, Enric Balletbo i Serra wrote: >> The get_edid() callback can be triggered anytime by an ioctl, i.e >> >> drm_mode_getconnector (ioctl)

Re: [PATCH 3/3] drm/bridge: ps8640: Rework power state handling

2020-06-20 Thread Sam Ravnborg
Hi Enric. On Mon, Jun 15, 2020 at 10:53:20PM +0200, Enric Balletbo i Serra wrote: > The get_edid() callback can be triggered anytime by an ioctl, i.e > > drm_mode_getconnector (ioctl) > -> drm_helper_probe_single_connector_modes >-> drm_bridge_connector_get_modes > ->

[PATCH 3/3] drm/bridge: ps8640: Rework power state handling

2020-06-16 Thread Enric Balletbo i Serra
The get_edid() callback can be triggered anytime by an ioctl, i.e drm_mode_getconnector (ioctl) -> drm_helper_probe_single_connector_modes -> drm_bridge_connector_get_modes -> ps8640_bridge_get_edid Actually if the bridge pre_enable() function was not called before