Re: [PATCH 3/3] drm/vkms: Reduce critical section in vblank_simulate

2019-09-03 Thread Daniel Vetter
On Tue, Sep 03, 2019 at 08:50:29AM -0400, Rodrigo Siqueira wrote: > Thanks for this patch! It looks good for me. > > Reviewed-by: Rodrigo Siqueira Thanks for taking a look at all this, entire series merged. With the r-b from Ville on patch 1, but I'm happy to further discuss your questions. Plus

Re: [PATCH 3/3] drm/vkms: Reduce critical section in vblank_simulate

2019-09-03 Thread Rodrigo Siqueira
Thanks for this patch! It looks good for me. Reviewed-by: Rodrigo Siqueira On 07/19, Daniel Vetter wrote: > We can reduce the critical section in vkms_vblank_simulate under > output->lock quite a lot: > > - hrtimer_forward_now just needs to be ordered correctly wrt > drm_crtc_handle_vblank. W

[PATCH 3/3] drm/vkms: Reduce critical section in vblank_simulate

2019-07-19 Thread Daniel Vetter
We can reduce the critical section in vkms_vblank_simulate under output->lock quite a lot: - hrtimer_forward_now just needs to be ordered correctly wrt drm_crtc_handle_vblank. We already access the hrtimer timestamp without locks. While auditing that I noticed that we don't correctly annotat