Re: [PATCH 3/3] drm: tiny: st7735r: Add support for Okaya RH128128T

2020-01-07 Thread Geert Uytterhoeven
Hi David, On Mon, Jan 6, 2020 at 6:12 PM David Lechner wrote: > On 1/6/20 3:28 AM, Geert Uytterhoeven wrote: > > On Sun, Jan 5, 2020 at 10:13 AM Sam Ravnborg wrote: > >> On Thu, Jan 02, 2020 at 03:12:46PM +0100, Geert Uytterhoeven wrote: > >>> Add support for the Okaya RH128128T display to the s

Re: [PATCH 3/3] drm: tiny: st7735r: Add support for Okaya RH128128T

2020-01-07 Thread Geert Uytterhoeven
Hi Sam, On Mon, Jan 6, 2020 at 6:08 PM Sam Ravnborg wrote: > > > On Thu, Jan 02, 2020 at 03:12:46PM +0100, Geert Uytterhoeven wrote: > > > > Add support for the Okaya RH128128T display to the st7735r driver. > > > > > > > > The RH128128T is a 128x128 1.44" TFT display driven by a Sitronix > > > >

Re: [PATCH 3/3] drm: tiny: st7735r: Add support for Okaya RH128128T

2020-01-06 Thread David Lechner
On 1/6/20 3:28 AM, Geert Uytterhoeven wrote: Hi Sam, On Sun, Jan 5, 2020 at 10:13 AM Sam Ravnborg wrote: Good to see we add more functionality to the smallest driver in DRM. The patch triggered a few comments - see below. Some comments relates to the original driver - and not your changes. T

Re: [PATCH 3/3] drm: tiny: st7735r: Add support for Okaya RH128128T

2020-01-06 Thread Sam Ravnborg
Hi Geert. > Thanks for your comments! > > > On Thu, Jan 02, 2020 at 03:12:46PM +0100, Geert Uytterhoeven wrote: > > > Add support for the Okaya RH128128T display to the st7735r driver. > > > > > > The RH128128T is a 128x128 1.44" TFT display driven by a Sitronix > > > ST7715R TFT Controller/Drive

Re: [PATCH 3/3] drm: tiny: st7735r: Add support for Okaya RH128128T

2020-01-06 Thread Geert Uytterhoeven
Hi Sam, On Sun, Jan 5, 2020 at 10:13 AM Sam Ravnborg wrote: > Good to see we add more functionality to the smallest driver in DRM. > The patch triggered a few comments - see below. > Some comments relates to the original driver - and not your changes. Thanks for your comments! > On Thu, Jan 02,

Re: [PATCH 3/3] drm: tiny: st7735r: Add support for Okaya RH128128T

2020-01-05 Thread Sam Ravnborg
Hi Geert. Good to see we add more functionality to the smallest driver in DRM. The patch triggered a few comments - see below. Some comments relates to the original driver - and not your changes. Sam On Thu, Jan 02, 2020 at 03:12:46PM +0100, Geert Uytterhoeven wrote: > Add support for th

[PATCH 3/3] drm: tiny: st7735r: Add support for Okaya RH128128T

2020-01-02 Thread Geert Uytterhoeven
Add support for the Okaya RH128128T display to the st7735r driver. The RH128128T is a 128x128 1.44" TFT display driven by a Sitronix ST7715R TFT Controller/Driver. The latter is very similar to the ST7735R, and can be handled by the existing st7735r driver. Signed-off-by: Geert Uytterhoeven ---