[PATCH 3/4] drm/msm: Add SYSPROF param (v2)

2022-03-03 Thread Rob Clark
From: Rob Clark Add a SYSPROF param for system profiling tools like Mesa's pps-producer (perfetto) to control behavior related to system-wide performance counter collection. In particular, for profiling, one wants to ensure that GPU context switches do not effect perfcounter state, and might

Re: [PATCH 3/4] drm/msm: Add SYSPROF param

2022-03-03 Thread Stephen Boyd
Quoting Rob Clark (2022-03-03 13:47:14) > On Thu, Mar 3, 2022 at 1:17 PM Rob Clark wrote: > > > > On Thu, Mar 3, 2022 at 12:47 PM Stephen Boyd wrote: > > > > > > Quoting Rob Clark (2022-03-03 11:46:47) > > > > + > > > > + /* then apply new value: */ > > > > > > It would be safer to swap

Re: [PATCH 3/4] drm/msm: Add SYSPROF param

2022-03-03 Thread Rob Clark
On Thu, Mar 3, 2022 at 1:17 PM Rob Clark wrote: > > On Thu, Mar 3, 2022 at 12:47 PM Stephen Boyd wrote: > > > > Quoting Rob Clark (2022-03-03 11:46:47) > > > diff --git a/drivers/gpu/drm/msm/msm_gpu.h b/drivers/gpu/drm/msm/msm_gpu.h > > > index fde9a29f884e..0ba1dbd4e50f 100644 > > > ---

Re: [PATCH 3/4] drm/msm: Add SYSPROF param

2022-03-03 Thread Rob Clark
On Thu, Mar 3, 2022 at 12:47 PM Stephen Boyd wrote: > > Quoting Rob Clark (2022-03-03 11:46:47) > > diff --git a/drivers/gpu/drm/msm/msm_gpu.h b/drivers/gpu/drm/msm/msm_gpu.h > > index fde9a29f884e..0ba1dbd4e50f 100644 > > --- a/drivers/gpu/drm/msm/msm_gpu.h > > +++

Re: [PATCH 3/4] drm/msm: Add SYSPROF param

2022-03-03 Thread Stephen Boyd
Quoting Rob Clark (2022-03-03 11:46:47) > diff --git a/drivers/gpu/drm/msm/msm_gpu.h b/drivers/gpu/drm/msm/msm_gpu.h > index fde9a29f884e..0ba1dbd4e50f 100644 > --- a/drivers/gpu/drm/msm/msm_gpu.h > +++ b/drivers/gpu/drm/msm/msm_gpu.h > @@ -330,6 +337,24 @@ struct msm_file_private { >

[PATCH 3/4] drm/msm: Add SYSPROF param

2022-03-03 Thread Rob Clark
From: Rob Clark Add a SYSPROF param for system profiling tools like Mesa's pps-producer (perfetto) to control behavior related to system-wide performance counter collection. In particular, for profiling, one wants to ensure that GPU context switches do not effect perfcounter state, and might