Hello Thomas,
On 2/2/22 09:23, Thomas Zimmermann wrote:
[snip]
>
> Thanks to both of you. I was asking because I found the code to be
> repetitive and it's not clear that these 3 statements belong together.
>
> I'd like to suggest to add a function
>
>ssd1307_write_cmds(client, len,
Hi
Am 01.02.22 um 15:36 schrieb Javier Martinez Canillas:
On 2/1/22 15:05, Geert Uytterhoeven wrote:
Hi Javier,
On Tue, Feb 1, 2022 at 2:02 PM Javier Martinez Canillas
wrote:
On 2/1/22 10:33, Thomas Zimmermann wrote:
+{
+u8 col_end = col_start + cols - 1;
+int ret;
+
+if
On 2/1/22 15:02, Andy Shevchenko wrote:
> On Tue, Feb 01, 2022 at 12:45:53PM +0100, Javier Martinez Canillas wrote:
>> On 2/1/22 10:44, Andy Shevchenko wrote:
>>> On Tue, Feb 01, 2022 at 01:14:22AM +0100, Javier Martinez Canillas wrote:
>
> ...
>
>>> The problem with no backward compatibility
On 2/1/22 15:05, Geert Uytterhoeven wrote:
> Hi Javier,
>
> On Tue, Feb 1, 2022 at 2:02 PM Javier Martinez Canillas
> wrote:
>> On 2/1/22 10:33, Thomas Zimmermann wrote:
+{
+u8 col_end = col_start + cols - 1;
+int ret;
+
+if (col_start == ssd1307->col_start
Hi Javier,
On Tue, Feb 1, 2022 at 2:02 PM Javier Martinez Canillas
wrote:
> On 2/1/22 10:33, Thomas Zimmermann wrote:
> >> +{
> >> +u8 col_end = col_start + cols - 1;
> >> +int ret;
> >> +
> >> +if (col_start == ssd1307->col_start && col_end == ssd1307->col_end)
> >> +
On Tue, Feb 01, 2022 at 12:45:53PM +0100, Javier Martinez Canillas wrote:
> On 2/1/22 10:44, Andy Shevchenko wrote:
> > On Tue, Feb 01, 2022 at 01:14:22AM +0100, Javier Martinez Canillas wrote:
...
> > The problem with no backward compatibility means that removal of old driver
> > makes users
On 2/1/22 10:33, Thomas Zimmermann wrote:
> Hi Javier,
>
> please see comments and questions below.
>
Thanks again for your comments.
[snip]
>>
>> +config TINYDRM_SSD1307
>
> TINYDRM is so 2010's. Just call it DRM.
>
Haha, Ok. I just followed what other drivers did and thought was a
On 2/1/22 10:44, Andy Shevchenko wrote:
> On Tue, Feb 01, 2022 at 01:14:22AM +0100, Javier Martinez Canillas wrote:
>> On 1/31/22 22:30, Sam Ravnborg wrote:
>>> On Mon, Jan 31, 2022 at 09:29:16PM +0100, Javier Martinez Canillas wrote:
>
> ...
>
>>> The driver uses the pwms property for the
On 2/1/22 10:41, Andy Shevchenko wrote:
> On Mon, Jan 31, 2022 at 10:30:46PM +0100, Sam Ravnborg wrote:
>> On Mon, Jan 31, 2022 at 09:29:16PM +0100, Javier Martinez Canillas wrote:
>
> ...
>
>>> +config TINYDRM_SSD1307
>>> + tristate "DRM support for Solomon SSD1307 OLED displays"
>> Use
On Tue, Feb 01, 2022 at 10:33:31AM +0100, Thomas Zimmermann wrote:
> Am 31.01.22 um 21:29 schrieb Javier Martinez Canillas:
> > +obj-$(CONFIG_TINYDRM_SSD1307) += ssd1307.o
>
> Maybe call it ssd130x
Either way it's good to list all supported models in "help" of Kconfig.
Also here
On Tue, Feb 01, 2022 at 01:14:22AM +0100, Javier Martinez Canillas wrote:
> On 1/31/22 22:30, Sam Ravnborg wrote:
> > On Mon, Jan 31, 2022 at 09:29:16PM +0100, Javier Martinez Canillas wrote:
...
> > The driver uses the pwms property for the backlight.
> > It would have been much better to bite
On Mon, Jan 31, 2022 at 10:30:46PM +0100, Sam Ravnborg wrote:
> On Mon, Jan 31, 2022 at 09:29:16PM +0100, Javier Martinez Canillas wrote:
...
> > +config TINYDRM_SSD1307
> > + tristate "DRM support for Solomon SSD1307 OLED displays"
> Use SSD130X here - so SSD1306 users can find it.
It's
Hi Javier,
please see comments and questions below.
Am 31.01.22 um 21:29 schrieb Javier Martinez Canillas:
Add a DRM driver for SSD1305, SSD1306, SSD1307 and SSD1309 Solomon OLED
controllers that can be programmed via an I2C interface. This is a port
of the ssd1307fb driver that already
Hello Sam,
Thanks for your suggestions.
On 1/31/22 22:30, Sam Ravnborg wrote:
> Hi Javier,
>
> On Mon, Jan 31, 2022 at 09:29:16PM +0100, Javier Martinez Canillas wrote:
>> Add a DRM driver for SSD1305, SSD1306, SSD1307 and SSD1309 Solomon OLED
>> controllers that can be programmed via an I2C
Hi Javier,
On Mon, Jan 31, 2022 at 09:29:16PM +0100, Javier Martinez Canillas wrote:
> Add a DRM driver for SSD1305, SSD1306, SSD1307 and SSD1309 Solomon OLED
> controllers that can be programmed via an I2C interface. This is a port
> of the ssd1307fb driver that already supports these devices.
>
Add a DRM driver for SSD1305, SSD1306, SSD1307 and SSD1309 Solomon OLED
controllers that can be programmed via an I2C interface. This is a port
of the ssd1307fb driver that already supports these devices.
A Device Tree binding is not added because the DRM driver is compatible
with the existing
16 matches
Mail list logo
