Re: [PATCH 3/4] phy: rockchip-typec: support DP phy switch

2017-03-09 Thread Brian Norris
On Thu, Mar 09, 2017 at 09:31:33AM +0100, Heiko Stuebner wrote: > Am Mittwoch, 8. März 2017, 19:10:50 CET schrieb Brian Norris: > > Another random point of contention (not worth too much, as the pattern > > is already set), but why do these deserve DT properties at all? The > > device already has

Re: [PATCH 3/4] phy: rockchip-typec: support DP phy switch

2017-03-09 Thread Brian Norris
Hi, On Thu, Mar 09, 2017 at 02:02:54AM +0100, Heiko Stuebner wrote: > Am Mittwoch, 8. März 2017, 16:39:23 CET schrieb Brian Norris: > > On Fri, Feb 10, 2017 at 03:44:13PM +0800, Chris Zhong wrote: > > > There are 2 Type-c PHYs in RK3399, but only one DP controller. Hence > > > only one PHY can

Re: [PATCH 3/4] phy: rockchip-typec: support DP phy switch

2017-03-09 Thread Brian Norris
On Fri, Feb 10, 2017 at 03:44:13PM +0800, Chris Zhong wrote: > There are 2 Type-c PHYs in RK3399, but only one DP controller. Hence > only one PHY can connect to DP controller at one time, the other should > be disconnected. The GRF_SOC_CON26 register has a switch bit to do it, > set this bit

Re: [PATCH 3/4] phy: rockchip-typec: support DP phy switch

2017-03-09 Thread Heiko Stübner
Hi Brian, Am Mittwoch, 8. März 2017, 19:10:50 CET schrieb Brian Norris: > On Thu, Mar 09, 2017 at 02:02:54AM +0100, Heiko Stuebner wrote: > > Am Mittwoch, 8. März 2017, 16:39:23 CET schrieb Brian Norris: > > > On Fri, Feb 10, 2017 at 03:44:13PM +0800, Chris Zhong wrote: > > > > There are 2 Type-c

Re: [PATCH 3/4] phy: rockchip-typec: support DP phy switch

2017-03-08 Thread Chris Zhong
Hi Heiko and Brain On 03/09/2017 09:02 AM, Heiko Stübner wrote: Am Mittwoch, 8. März 2017, 16:39:23 CET schrieb Brian Norris: On Fri, Feb 10, 2017 at 03:44:13PM +0800, Chris Zhong wrote: There are 2 Type-c PHYs in RK3399, but only one DP controller. Hence only one PHY can connect to DP

Re: [PATCH 3/4] phy: rockchip-typec: support DP phy switch

2017-03-08 Thread Heiko Stübner
Am Mittwoch, 8. März 2017, 16:39:23 CET schrieb Brian Norris: > On Fri, Feb 10, 2017 at 03:44:13PM +0800, Chris Zhong wrote: > > There are 2 Type-c PHYs in RK3399, but only one DP controller. Hence > > only one PHY can connect to DP controller at one time, the other should > > be disconnected. The

[PATCH 3/4] phy: rockchip-typec: support DP phy switch

2017-02-09 Thread Chris Zhong
There are 2 Type-c PHYs in RK3399, but only one DP controller. Hence only one PHY can connect to DP controller at one time, the other should be disconnected. The GRF_SOC_CON26 register has a switch bit to do it, set this bit means enable PHY 1, clear this bit means enable PHY 0. Signed-off-by: