Re: [PATCH 3/8] drm/mediatek: don't open-code drm_gem_fb_create

2019-11-22 Thread Daniel Vetter
On Fri, Nov 22, 2019 at 03:42:39PM +0800, CK Hu wrote: > Hi, Daniel: > > On Fri, 2019-11-15 at 10:21 +0100, Daniel Vetter wrote: > > Aside: There's a few other fb_create implementations which > > simply check for valid buffer format (or an approximation thereof), > > and then call drm_gem_fb_creat

Re: [PATCH 3/8] drm/mediatek: don't open-code drm_gem_fb_create

2019-11-21 Thread CK Hu
Hi, Daniel: On Fri, 2019-11-15 at 10:21 +0100, Daniel Vetter wrote: > Aside: There's a few other fb_create implementations which > simply check for valid buffer format (or an approximation thereof), > and then call drm_gem_fb_create. For atomic drivers at least we could > walk all planes and make

[PATCH 3/8] drm/mediatek: don't open-code drm_gem_fb_create

2019-11-15 Thread Daniel Vetter
Aside: There's a few other fb_create implementations which simply check for valid buffer format (or an approximation thereof), and then call drm_gem_fb_create. For atomic drivers at least we could walk all planes and make sure the format/modifier combo is valid, and remove even more code. For non-