Re: [PATCH 36/37] drm/zte: Drop drm_vblank_cleanup

2017-05-26 Thread Shawn Guo
On Fri, May 26, 2017 at 08:57:32AM +0200, Daniel Vetter wrote: > On Thu, May 25, 2017 at 5:01 AM, Shawn Guo wrote: > > On Wed, May 24, 2017 at 04:52:11PM +0200, Daniel Vetter wrote: > >> It again looks all cargo-culted for no good reasons. > > > > drm_vblank_cleanup() is

Re: [PATCH 36/37] drm/zte: Drop drm_vblank_cleanup

2017-05-26 Thread Daniel Vetter
On Thu, May 25, 2017 at 5:01 AM, Shawn Guo wrote: > On Wed, May 24, 2017 at 04:52:11PM +0200, Daniel Vetter wrote: >> It again looks all cargo-culted for no good reasons. > > drm_vblank_cleanup() is called to release the resources allocated by > drm_vblank_init(). I think

Re: [PATCH 36/37] drm/zte: Drop drm_vblank_cleanup

2017-05-24 Thread Shawn Guo
On Wed, May 24, 2017 at 04:52:11PM +0200, Daniel Vetter wrote: > It again looks all cargo-culted for no good reasons. drm_vblank_cleanup() is called to release the resources allocated by drm_vblank_init(). I think that's the reason, no? Shawn > > Cc: Shawn Guo >

[PATCH 36/37] drm/zte: Drop drm_vblank_cleanup

2017-05-24 Thread Daniel Vetter
It again looks all cargo-culted for no good reasons. Cc: Shawn Guo Signed-off-by: Daniel Vetter --- drivers/gpu/drm/zte/zx_drm_drv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c