Re: [PATCH 4/4] drm/tinydrm: Add RePaper e-ink driver

2017-06-07 Thread Noralf Trønnes
Den 07.06.2017 14.14, skrev Emil Velikov: On 7 June 2017 at 12:52, Noralf Trønnes wrote: Hi Emil, Den 07.06.2017 11.30, skrev Emil Velikov: Hi Noralf, Small drive-by comment, noticed while going through my morning coffee. By no means a full review. On 2 June 2017 at 12:49, Noralf Trønnes

Re: [PATCH 4/4] drm/tinydrm: Add RePaper e-ink driver

2017-06-07 Thread Noralf Trønnes
Den 07.06.2017 14.11, skrev Ilia Mirkin: On Wed, Jun 7, 2017 at 7:52 AM, Noralf Trønnes wrote: Hi Emil, Den 07.06.2017 11.30, skrev Emil Velikov: Hi Noralf, Small drive-by comment, noticed while going through my morning coffee. By no means a full review. On 2 June 2017 at 12:49, Noralf Tr

Re: [PATCH 4/4] drm/tinydrm: Add RePaper e-ink driver

2017-06-07 Thread Emil Velikov
On 7 June 2017 at 12:52, Noralf Trønnes wrote: > Hi Emil, > > > Den 07.06.2017 11.30, skrev Emil Velikov: >> >> Hi Noralf, >> >> Small drive-by comment, noticed while going through my morning coffee. >> By no means a full review. >> >> On 2 June 2017 at 12:49, Noralf Trønnes wrote: >> >> >>> +/*

Re: [PATCH 4/4] drm/tinydrm: Add RePaper e-ink driver

2017-06-07 Thread Ilia Mirkin
On Wed, Jun 7, 2017 at 7:52 AM, Noralf Trønnes wrote: > Hi Emil, > > > Den 07.06.2017 11.30, skrev Emil Velikov: >> >> Hi Noralf, >> >> Small drive-by comment, noticed while going through my morning coffee. >> By no means a full review. >> >> On 2 June 2017 at 12:49, Noralf Trønnes wrote: >> >> >

Re: [PATCH 4/4] drm/tinydrm: Add RePaper e-ink driver

2017-06-07 Thread Noralf Trønnes
Hi Emil, Den 07.06.2017 11.30, skrev Emil Velikov: Hi Noralf, Small drive-by comment, noticed while going through my morning coffee. By no means a full review. On 2 June 2017 at 12:49, Noralf Trønnes wrote: +/* pixels on display are numbered from 1 */ +static void repaper_all_pixels(struc

Re: [PATCH 4/4] drm/tinydrm: Add RePaper e-ink driver

2017-06-07 Thread Emil Velikov
Hi Noralf, Small drive-by comment, noticed while going through my morning coffee. By no means a full review. On 2 June 2017 at 12:49, Noralf Trønnes wrote: > +/* pixels on display are numbered from 1 */ > +static void repaper_all_pixels(struct repaper_epd *epd, u8 **pp, > +

[PATCH 4/4] drm/tinydrm: Add RePaper e-ink driver

2017-06-02 Thread Noralf Trønnes
This adds support for the Pervasive Displays RePaper branded displays. The controller code is taken from the userspace driver available through repaper.org. Only the V231 film is supported since the others are EOL. Signed-off-by: Noralf Trønnes --- MAINTAINERS |6 + dri