Re: [PATCH 5/5] drm/bridge: ti-tfp410: Report input bus config through bridge timings

2018-12-11 Thread Laurent Pinchart
Hi Jyri, On Tuesday, 11 December 2018 16:48:16 EET Jyri Sarha wrote: > On 06/12/2018 22:26, Laurent Pinchart wrote: > > The TFP410 supports configurable pixel clock sampling edge and data > > de-skew adjustments. The configuration can be set through I2C or > > dedicated chip pins. > > > > Report

Re: [PATCH 5/5] drm/bridge: ti-tfp410: Report input bus config through bridge timings

2018-12-11 Thread Jyri Sarha
On 11/12/2018 17:19, Tomi Valkeinen wrote: > On 11/12/18 16:48, Jyri Sarha wrote: > >>> + /* Get the setup and hold time from vendor-specific properties. */ >>> + of_property_read_u32(dvi->dev->of_node, "ti,deskew", (u32 *)); >>> + if (deskew < -4 || deskew > 3) >>> + return

Re: [PATCH 5/5] drm/bridge: ti-tfp410: Report input bus config through bridge timings

2018-12-11 Thread Tomi Valkeinen
On 11/12/18 16:48, Jyri Sarha wrote: >> +/* Get the setup and hold time from vendor-specific properties. */ >> +of_property_read_u32(dvi->dev->of_node, "ti,deskew", (u32 *)); >> +if (deskew < -4 || deskew > 3) >> +return -EINVAL; > > Is "ti,deskew" property documented

Re: [PATCH 5/5] drm/bridge: ti-tfp410: Report input bus config through bridge timings

2018-12-11 Thread Jyri Sarha
On 06/12/2018 22:26, Laurent Pinchart wrote: > The TFP410 supports configurable pixel clock sampling edge and data > de-skew adjustments. The configuration can be set through I2C or > dedicated chip pins. > > Report the configuration through the drm_bridge timings. As the > ti-tftp410 driver

[PATCH 5/5] drm/bridge: ti-tfp410: Report input bus config through bridge timings

2018-12-06 Thread Laurent Pinchart
The TFP410 supports configurable pixel clock sampling edge and data de-skew adjustments. The configuration can be set through I2C or dedicated chip pins. Report the configuration through the drm_bridge timings. As the ti-tftp410 driver doesn't support configuring the chip through I2C, we simply