Re: [PATCH 5/6] drm/msm/dpu: remove struct dpu_encoder_irq

2022-02-16 Thread Dmitry Baryshkov
On 16/02/2022 04:56, Abhinav Kumar wrote: On 2/1/2022 7:10 AM, Dmitry Baryshkov wrote: Remove additional indirection: specify IRQ callbacks and IRQ indices directly rather than through the pointer in the irq structure. For each IRQ we have a constant IRQ callback. This change simplifies code

Re: [PATCH 5/6] drm/msm/dpu: remove struct dpu_encoder_irq

2022-02-16 Thread Dmitry Baryshkov
On 16/02/2022 05:22, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-02-01 07:10:55) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h index ff2218155b44..803fd6f25da1 100644 ---

Re: [PATCH 5/6] drm/msm/dpu: remove struct dpu_encoder_irq

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-01 07:10:55) > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h > b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h > index ff2218155b44..803fd6f25da1 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h > +++

Re: [PATCH 5/6] drm/msm/dpu: remove struct dpu_encoder_irq

2022-02-15 Thread Abhinav Kumar
On 2/1/2022 7:10 AM, Dmitry Baryshkov wrote: Remove additional indirection: specify IRQ callbacks and IRQ indices directly rather than through the pointer in the irq structure. For each IRQ we have a constant IRQ callback. This change simplifies code review as the reader no longer needs to

[PATCH 5/6] drm/msm/dpu: remove struct dpu_encoder_irq

2022-02-01 Thread Dmitry Baryshkov
Remove additional indirection: specify IRQ callbacks and IRQ indices directly rather than through the pointer in the irq structure. For each IRQ we have a constant IRQ callback. This change simplifies code review as the reader no longer needs to remember which function is called. Signed-off-by: