Re: [PATCH 5/6] drm: rcar-du: Fix setting a reserved bit in DPLLCR

2023-01-20 Thread Tomi Valkeinen
On 18/01/2023 23:38, Laurent Pinchart wrote: Hi Tomi, Thank you for the patch. On Tue, Jan 17, 2023 at 03:51:53PM +0200, Tomi Valkeinen wrote: On H3 ES1 two bits in DPLLCR are used to select the DU input dot clock s/ES1/ES1.x/ Same below. Ok. But I do wonder, is there a difference? What's

Re: [PATCH 5/6] drm: rcar-du: Fix setting a reserved bit in DPLLCR

2023-01-20 Thread Tomi Valkeinen
On 19/01/2023 11:40, Laurent Pinchart wrote: Hi Tomi, On Thu, Jan 19, 2023 at 11:17:58AM +0200, Tomi Valkeinen wrote: On 18/01/2023 23:38, Laurent Pinchart wrote: On Tue, Jan 17, 2023 at 03:51:53PM +0200, Tomi Valkeinen wrote: On H3 ES1 two bits in DPLLCR are used to select the DU input dot c

Re: [PATCH 5/6] drm: rcar-du: Fix setting a reserved bit in DPLLCR

2023-01-19 Thread Laurent Pinchart
Hi Tomi, On Thu, Jan 19, 2023 at 12:24:48PM +0200, Tomi Valkeinen wrote: > On 19/01/2023 11:40, Laurent Pinchart wrote: > > On Thu, Jan 19, 2023 at 11:17:58AM +0200, Tomi Valkeinen wrote: > >> On 18/01/2023 23:38, Laurent Pinchart wrote: > >>> On Tue, Jan 17, 2023 at 03:51:53PM +0200, Tomi Valkein

Re: [PATCH 5/6] drm: rcar-du: Fix setting a reserved bit in DPLLCR

2023-01-19 Thread Laurent Pinchart
Hi Tomi, On Thu, Jan 19, 2023 at 11:17:58AM +0200, Tomi Valkeinen wrote: > On 18/01/2023 23:38, Laurent Pinchart wrote: > > On Tue, Jan 17, 2023 at 03:51:53PM +0200, Tomi Valkeinen wrote: > >> On H3 ES1 two bits in DPLLCR are used to select the DU input dot clock > > > > s/ES1/ES1.x/ > > > > Sam

Re: [PATCH 5/6] drm: rcar-du: Fix setting a reserved bit in DPLLCR

2023-01-18 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Jan 17, 2023 at 03:51:53PM +0200, Tomi Valkeinen wrote: > On H3 ES1 two bits in DPLLCR are used to select the DU input dot clock s/ES1/ES1.x/ Same below. > source. These are bits 20 and 21 for DU2, and bits 22 and 23 for DU1. On > non-ES1, only the hig

[PATCH 5/6] drm: rcar-du: Fix setting a reserved bit in DPLLCR

2023-01-18 Thread Tomi Valkeinen
On H3 ES1 two bits in DPLLCR are used to select the DU input dot clock source. These are bits 20 and 21 for DU2, and bits 22 and 23 for DU1. On non-ES1, only the higher bits are used (bits 21 and 23), and the lower bits are reserved and should be set to 0 (or not set at all). The current code alwa