Re: [PATCH 5/8] mm: simplify freeing of devmap managed pages

2022-02-08 Thread Chaitanya Kulkarni
> -static inline bool page_is_devmap_managed(struct page *page) > +bool __put_devmap_managed_page(struct page *page); > +static inline bool put_devmap_managed_page(struct page *page) > { > if (!static_branch_unlikely(_managed_key)) > return false; > if

Re: [PATCH 5/8] mm: simplify freeing of devmap managed pages

2022-02-07 Thread Dan Williams
On Sun, Feb 6, 2022 at 10:33 PM Christoph Hellwig wrote: > > Make put_devmap_managed_page return if it took charge of the page > or not and remove the separate page_is_devmap_managed helper. Looks good to me: Reviewed-by: Dan Williams

Re: [PATCH 5/8] mm: simplify freeing of devmap managed pages

2022-02-07 Thread Jason Gunthorpe
On Mon, Feb 07, 2022 at 07:32:46AM +0100, Christoph Hellwig wrote: > Make put_devmap_managed_page return if it took charge of the page > or not and remove the separate page_is_devmap_managed helper. > > Signed-off-by: Christoph Hellwig > --- > include/linux/mm.h | 34