Re: [PATCH 5/9] vfio: Pass in a struct vfio_device * to vfio_dma_rw()

2022-04-13 Thread Jason Gunthorpe
On Wed, Apr 13, 2022 at 08:00:08AM +0200, Christoph Hellwig wrote: > This looks good execept the extern nitpick: > > Reviewed-by: Christoph Hellwig > > However I'd move this before the previous patch. More of the explanation > there. Yes, that looks good, done Thanks, Jason

[PATCH 5/9] vfio: Pass in a struct vfio_device * to vfio_dma_rw()

2022-04-12 Thread Jason Gunthorpe
Every caller has a readily available vfio_device pointer, use that instead of passing in a generic struct device. The struct vfio_device already contains the group we need so this avoids complexity, extra refcountings, and a confusing lifecycle model. Signed-off-by: Jason Gunthorpe ---