[PATCH 6/7] drm/rcar: gem: dumb: pitch is an output

2014-11-06 Thread Laurent Pinchart
Hi Russell, On Thursday 06 November 2014 00:54:51 Russell King - ARM Linux wrote: > On Wed, Nov 05, 2014 at 08:47:07PM +0200, Laurent Pinchart wrote: > > (On a side note I believe treating the pitch and size arguments as inputs > > could be a worthwhile extension to the API, but given that we

[PATCH 6/7] drm/rcar: gem: dumb: pitch is an output

2014-11-06 Thread Russell King - ARM Linux
On Wed, Nov 05, 2014 at 08:47:07PM +0200, Laurent Pinchart wrote: > (On a side note I believe treating the pitch and size arguments as inputs > could be a worthwhile extension to the API, but given that we haven't > rejected incorrect values in the past we're pretty much stuck). The bigger

[PATCH 6/7] drm/rcar: gem: dumb: pitch is an output

2014-11-05 Thread Laurent Pinchart
Hi Thierry, Thank you for the patch. On Wednesday 05 November 2014 14:25:18 Thierry Reding wrote: > From: Thierry Reding > > When creating a dumb buffer object using the DRM_IOCTL_MODE_CREATE_DUMB > IOCTL, only the width, height, bpp and flags fields are inputs. The > caller is not guaranteed

[PATCH 6/7] drm/rcar: gem: dumb: pitch is an output

2014-11-05 Thread Daniel Vetter
On Wed, Nov 05, 2014 at 02:25:18PM +0100, Thierry Reding wrote: > From: Thierry Reding > > When creating a dumb buffer object using the DRM_IOCTL_MODE_CREATE_DUMB > IOCTL, only the width, height, bpp and flags fields are inputs. The > caller is not guaranteed to zero out or set handle, pitch and

[PATCH 6/7] drm/rcar: gem: dumb: pitch is an output

2014-11-05 Thread Thierry Reding
From: Thierry Reding When creating a dumb buffer object using the DRM_IOCTL_MODE_CREATE_DUMB IOCTL, only the width, height, bpp and flags fields are inputs. The caller is not guaranteed to zero out or set handle, pitch and size. Drivers must not treat these values as possible