[PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-16 Thread Jean Delvare
On Tue, 15 Jun 2010 09:20:39 -0700, David Daney wrote: > On 06/15/2010 04:40 AM, Jean Delvare wrote: > > __process_new_adapter() calls i2c_do_add_adapter() which always returns > > 0. Why should I check the return value of bus_for_each_drv() when I > > know it will always be 0 by construction? > >

Re: [PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-16 Thread David Daney
On 06/15/2010 04:40 AM, Jean Delvare wrote: Hi David, On Mon, 14 Jun 2010 14:28:57 -0700, David Daney wrote: On 06/14/2010 01:53 PM, Jean Delvare wrote: Hi Justin, On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote: could be a right solution, could be wrong here is the warning:

Re: [PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-16 Thread Justin P. Mattock
On 06/15/2010 04:43 AM, Jean Delvare wrote: Hi Justin, On Mon, 14 Jun 2010 14:06:12 -0700, Justin P. Mattock wrote: On 06/14/2010 01:53 PM, Jean Delvare wrote: Hi Justin, On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote: could be a right solution, could be wrong here is the

Re: [PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-16 Thread Jean Delvare
On Tue, 15 Jun 2010 09:20:39 -0700, David Daney wrote: On 06/15/2010 04:40 AM, Jean Delvare wrote: __process_new_adapter() calls i2c_do_add_adapter() which always returns 0. Why should I check the return value of bus_for_each_drv() when I know it will always be 0 by construction? Also

[PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-15 Thread Justin P. Mattock
On 06/15/2010 04:43 AM, Jean Delvare wrote: > Hi Justin, > > On Mon, 14 Jun 2010 14:06:12 -0700, Justin P. Mattock wrote: >> On 06/14/2010 01:53 PM, Jean Delvare wrote: >>> Hi Justin, >>> >>> On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote: could be a right solution, could be

[PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-15 Thread David Daney
On 06/15/2010 04:40 AM, Jean Delvare wrote: > Hi David, > > On Mon, 14 Jun 2010 14:28:57 -0700, David Daney wrote: >> On 06/14/2010 01:53 PM, Jean Delvare wrote: >>> Hi Justin, >>> >>> On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote: could be a right solution, could be wrong

[PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-14 Thread Jean Delvare
Hi Justin, On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote: > could be a right solution, could be wrong > here is the warning: > CC drivers/i2c/i2c-core.o > drivers/i2c/i2c-core.c: In function 'i2c_register_adapter': > drivers/i2c/i2c-core.c:757:15: warning: variable 'dummy'

[PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-14 Thread David Daney
On 06/14/2010 01:53 PM, Jean Delvare wrote: > Hi Justin, > > On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote: >> could be a right solution, could be wrong >> here is the warning: >>CC drivers/i2c/i2c-core.o >> drivers/i2c/i2c-core.c: In function 'i2c_register_adapter': >>

[PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-14 Thread Justin P. Mattock
On 06/14/2010 01:53 PM, Jean Delvare wrote: > Hi Justin, > > On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote: >> could be a right solution, could be wrong >> here is the warning: >>CC drivers/i2c/i2c-core.o >> drivers/i2c/i2c-core.c: In function 'i2c_register_adapter': >>

[PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-14 Thread Justin P. Mattock
could be a right solution, could be wrong here is the warning: CC drivers/i2c/i2c-core.o drivers/i2c/i2c-core.c: In function 'i2c_register_adapter': drivers/i2c/i2c-core.c:757:15: warning: variable 'dummy' set but not used Signed-off-by: Justin P. Mattock --- drivers/i2c/i2c-core.c |

Re: [PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-14 Thread David Daney
On 06/14/2010 01:53 PM, Jean Delvare wrote: Hi Justin, On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote: could be a right solution, could be wrong here is the warning: CC drivers/i2c/i2c-core.o drivers/i2c/i2c-core.c: In function 'i2c_register_adapter':

[PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-14 Thread Justin P. Mattock
could be a right solution, could be wrong here is the warning: CC drivers/i2c/i2c-core.o drivers/i2c/i2c-core.c: In function 'i2c_register_adapter': drivers/i2c/i2c-core.c:757:15: warning: variable 'dummy' set but not used Signed-off-by: Justin P. Mattock justinmatt...@gmail.com ---

Re: [PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-14 Thread Jean Delvare
Hi Justin, On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote: could be a right solution, could be wrong here is the warning: CC drivers/i2c/i2c-core.o drivers/i2c/i2c-core.c: In function 'i2c_register_adapter': drivers/i2c/i2c-core.c:757:15: warning: variable 'dummy' set but

Re: [PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-14 Thread Justin P. Mattock
On 06/14/2010 01:53 PM, Jean Delvare wrote: Hi Justin, On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote: could be a right solution, could be wrong here is the warning: CC drivers/i2c/i2c-core.o drivers/i2c/i2c-core.c: In function 'i2c_register_adapter':