Re: [PATCH 7/7] drm/panel: sitronix-st7789v: Check display ID

2023-06-16 Thread Sebastian Reichel
Hi, On Fri, Jun 16, 2023 at 12:13:45PM +0200, Miquel Raynal wrote: > s...@kernel.org wrote on Thu, 15 Jun 2023 01:27:24 +0200: > > On Sat, Jun 10, 2023 at 10:45:25PM +0200, Sam Ravnborg wrote: > > > On Fri, Jun 09, 2023 at 04:59:51PM +0200, Miquel Raynal wrote: > > > > A very basic debugging rul

Re: [PATCH 7/7] drm/panel: sitronix-st7789v: Check display ID

2023-06-16 Thread Miquel Raynal
Hi Sebastian, s...@kernel.org wrote on Thu, 15 Jun 2023 01:27:24 +0200: > Hi, > > On Sat, Jun 10, 2023 at 10:45:25PM +0200, Sam Ravnborg wrote: > > Hi Miquel, > > > > On Fri, Jun 09, 2023 at 04:59:51PM +0200, Miquel Raynal wrote: > > > A very basic debugging rule when a device is connected fo

Re: [PATCH 7/7] drm/panel: sitronix-st7789v: Check display ID

2023-06-14 Thread Sebastian Reichel
Hi, On Sat, Jun 10, 2023 at 10:45:25PM +0200, Sam Ravnborg wrote: > Hi Miquel, > > On Fri, Jun 09, 2023 at 04:59:51PM +0200, Miquel Raynal wrote: > > A very basic debugging rule when a device is connected for the first > > time is to access a read-only register which contains known data in > > or

Re: [PATCH 7/7] drm/panel: sitronix-st7789v: Check display ID

2023-06-12 Thread Michael Riesch
Hi Miquel, On 6/9/23 16:59, Miquel Raynal wrote: > A very basic debugging rule when a device is connected for the first > time is to access a read-only register which contains known data in > order to ensure the communication protocol is properly working. This > driver lacked any read helper which

Re: [PATCH 7/7] drm/panel: sitronix-st7789v: Check display ID

2023-06-10 Thread Sam Ravnborg
Hi Miquel, On Fri, Jun 09, 2023 at 04:59:51PM +0200, Miquel Raynal wrote: > A very basic debugging rule when a device is connected for the first > time is to access a read-only register which contains known data in > order to ensure the communication protocol is properly working. This > driver lac

[PATCH 7/7] drm/panel: sitronix-st7789v: Check display ID

2023-06-09 Thread Miquel Raynal
A very basic debugging rule when a device is connected for the first time is to access a read-only register which contains known data in order to ensure the communication protocol is properly working. This driver lacked any read helper which is often a critical peace for fastening bring-ups. Add a