Re: [PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function

2017-07-03 Thread Jyri Sarha
On 06/28/17 00:16, Laurent Pinchart wrote: > The old state is useful for drivers that need to perform operations at > enable time that depend on the transition between the old and new > states. > > While at it, rename the operation to .atomic_enable() to be consistent > with .atomic_disable(), as

Re: [PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function

2017-06-29 Thread Thomas Hellstrom
For the vmwgfx part: Reviewed-by: Thomas Hellstrom On 06/27/2017 11:16 PM, Laurent Pinchart wrote: The old state is useful for drivers that need to perform operations at enable time that depend on the transition between the old and new states. While at it, rename the operation to .atomic_en

Re: [PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function

2017-06-29 Thread Vincent ABRIOU
On 06/27/2017 11:16 PM, Laurent Pinchart wrote: > The old state is useful for drivers that need to perform operations at > enable time that depend on the transition between the old and new > states. > > While at it, rename the operation to .atomic_enable() to be consistent > with .atomic_disable

Re: [PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function

2017-06-29 Thread Philippe CORNU
On 06/27/2017 11:16 PM, Laurent Pinchart wrote: > The old state is useful for drivers that need to perform operations at > enable time that depend on the transition between the old and new > states. > > While at it, rename the operation to .atomic_enable() to be consistent > with .atomic_disable

Re: [PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function

2017-06-28 Thread Alexey Brodkin
Hi Laurent, On Wed, 2017-06-28 at 00:16 +0300, Laurent Pinchart wrote: > The old state is useful for drivers that need to perform operations at > enable time that depend on the transition between the old and new > states. > > While at it, rename the operation to .atomic_enable() to be consistent

Re: [PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function

2017-06-28 Thread dri-devel-bounces
,Thierry Reding ,Thomas Hellstrom ,Tomi Valkeinen ,VMware Graphics ,Vincent Abriou ,Xinliang Liu ,Xinwei Kong ,Yannick Fertre From: Stefan Agner Message-ID: <961a615d-ed2e-4fa2-a49e-bb250f3e9...@agner.ch> On June 27, 2017 3:16:20 PM MDT, Laurent Pinchart wrote: >The old state is useful f

Re: [PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function

2017-06-28 Thread Laurent Pinchart
Hi Liviu, On Wednesday 28 Jun 2017 14:41:49 Liviu Dudau wrote: > On Wed, Jun 28, 2017 at 12:16:20AM +0300, Laurent Pinchart wrote: > > The old state is useful for drivers that need to perform operations at > > enable time that depend on the transition between the old and new > > states. > > > > W

Re: [PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function

2017-06-28 Thread Liviu Dudau
On Wed, Jun 28, 2017 at 12:16:20AM +0300, Laurent Pinchart wrote: > The old state is useful for drivers that need to perform operations at > enable time that depend on the transition between the old and new > states. > > While at it, rename the operation to .atomic_enable() to be consistent > with

Re: [PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function

2017-06-28 Thread Laurent Pinchart
Hi Daniel, On Wednesday 28 Jun 2017 09:42:54 Daniel Vetter wrote: > On Wed, Jun 28, 2017 at 12:16:20AM +0300, Laurent Pinchart wrote: > > diff --git a/include/drm/drm_modeset_helper_vtables.h > > b/include/drm/drm_modeset_helper_vtables.h index > > 474a1029ec79..d74a2cafc3de 100644 > > --- a/inclu

Re: [PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function

2017-06-28 Thread Boris Brezillon
Le Wed, 28 Jun 2017 00:16:20 +0300, Laurent Pinchart a écrit : > The old state is useful for drivers that need to perform operations at > enable time that depend on the transition between the old and new > states. > > While at it, rename the operation to .atomic_enable() to be consistent > with

Re: [PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function

2017-06-28 Thread Philipp Zabel
On Wed, 2017-06-28 at 00:16 +0300, Laurent Pinchart wrote: > The old state is useful for drivers that need to perform operations at > enable time that depend on the transition between the old and new > states. > > While at it, rename the operation to .atomic_enable() to be consistent > with .atomi

Re: [PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function

2017-06-28 Thread Daniel Vetter
On Wed, Jun 28, 2017 at 12:16:20AM +0300, Laurent Pinchart wrote: > diff --git a/include/drm/drm_modeset_helper_vtables.h > b/include/drm/drm_modeset_helper_vtables.h > index 474a1029ec79..d74a2cafc3de 100644 > --- a/include/drm/drm_modeset_helper_vtables.h > +++ b/include/drm/drm_modeset_helper_v

Re: [PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function

2017-06-27 Thread Maxime Ripard
On Wed, Jun 28, 2017 at 12:16:20AM +0300, Laurent Pinchart wrote: > The old state is useful for drivers that need to perform operations at > enable time that depend on the transition between the old and new > states. > > While at it, rename the operation to .atomic_enable() to be consistent > with

[PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function

2017-06-27 Thread Laurent Pinchart
The old state is useful for drivers that need to perform operations at enable time that depend on the transition between the old and new states. While at it, rename the operation to .atomic_enable() to be consistent with .atomic_disable(), as the .enable() operation is used by atomic helpers only.

[PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function

2017-06-27 Thread Laurent Pinchart
The old state is useful for drivers that need to perform operations at enable time that depend on the transition between the old and new states. While at it, rename the operation to .atomic_enable() to be consistent with .atomic_disable(), as the .enable() operation is used by atomic helpers only.