Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-21 Thread H. Nikolaus Schaller
> Am 21.12.2023 um 09:58 schrieb Maxime Ripard : > > Cool, so what you're saying is that your plan is to support those GPUs > upstream in the imagination driver? Yes, I would like to see PowerVR Series 5 SGX supported upstream since there are still so many devices in the wild which could use

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-21 Thread Maxime Ripard
On Tue, Dec 19, 2023 at 11:19:49AM -0600, Andrew Davis wrote: > On 12/18/23 4:54 AM, H. Nikolaus Schaller wrote: > > > > > > > Am 18.12.2023 um 11:14 schrieb Maxime Ripard : > > > > > > On Mon, Dec 18, 2023 at 10:28:09AM +0100, H. Nikolaus Schaller wrote: > > > > Hi Maxime, > > > > > > > > >

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-21 Thread Maxime Ripard
On Mon, Dec 18, 2023 at 11:54:47AM +0100, H. Nikolaus Schaller wrote: > > > > Am 18.12.2023 um 11:14 schrieb Maxime Ripard : > > > > On Mon, Dec 18, 2023 at 10:28:09AM +0100, H. Nikolaus Schaller wrote: > >> Hi Maxime, > >> > >>> Am 15.12.2023 um 14:33 schrieb Maxime Ripard : > >>> > > >

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-19 Thread Andrew Davis
On 12/18/23 4:54 AM, H. Nikolaus Schaller wrote: Am 18.12.2023 um 11:14 schrieb Maxime Ripard : On Mon, Dec 18, 2023 at 10:28:09AM +0100, H. Nikolaus Schaller wrote: Hi Maxime, Am 15.12.2023 um 14:33 schrieb Maxime Ripard : It's for a separate architecture, with a separate driver,

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-18 Thread Maxime Ripard
On Mon, Dec 18, 2023 at 10:28:09AM +0100, H. Nikolaus Schaller wrote: > Hi Maxime, > > > Am 15.12.2023 um 14:33 schrieb Maxime Ripard : > > > >>> > >>> It's for a separate architecture, with a separate driver, maintained out > >>> of tree by a separate community, with a separate set of

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-18 Thread H. Nikolaus Schaller
> Am 18.12.2023 um 11:14 schrieb Maxime Ripard : > > On Mon, Dec 18, 2023 at 10:28:09AM +0100, H. Nikolaus Schaller wrote: >> Hi Maxime, >> >>> Am 15.12.2023 um 14:33 schrieb Maxime Ripard : >>> > > It's for a separate architecture, with a separate driver, maintained out > of

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-18 Thread H . Nikolaus Schaller
Hi Maxime, > Am 15.12.2023 um 14:33 schrieb Maxime Ripard : > >>> >>> It's for a separate architecture, with a separate driver, maintained out >>> of tree by a separate community, with a separate set of requirements as >>> evidenced by the other thread. And that's all fine in itself, but >>>

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-15 Thread Maxime Ripard
On Thu, Dec 07, 2023 at 11:33:53AM +0100, H. Nikolaus Schaller wrote: > Hi Maxime, > > > Am 07.12.2023 um 10:20 schrieb Maxime Ripard : > > > > On Tue, Dec 05, 2023 at 02:50:08PM +0100, H. Nikolaus Schaller wrote: > >> Hi, > >> > >>> Am 05.12.2023 um 14:29 schrieb Maxime Ripard : > >>> > >>>

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-07 Thread H. Nikolaus Schaller
Hi Maxime, > Am 07.12.2023 um 10:20 schrieb Maxime Ripard : > > On Tue, Dec 05, 2023 at 02:50:08PM +0100, H. Nikolaus Schaller wrote: >> Hi, >> >>> Am 05.12.2023 um 14:29 schrieb Maxime Ripard : >>> >>> Hi, >>> >>> On Tue, Dec 05, 2023 at 09:18:58AM +0100, H. Nikolaus Schaller wrote: > Am

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-07 Thread Maxime Ripard
On Tue, Dec 05, 2023 at 02:50:08PM +0100, H. Nikolaus Schaller wrote: > Hi, > > > Am 05.12.2023 um 14:29 schrieb Maxime Ripard : > > > > Hi, > > > > On Tue, Dec 05, 2023 at 09:18:58AM +0100, H. Nikolaus Schaller wrote: > >>> Am 05.12.2023 um 07:57 schrieb Maxime Ripard : > >>> > >>> On Mon,

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-06 Thread Tony Lindgren
* Andreas Kemnade [231205 09:43]: > On Tue, 5 Dec 2023 10:27:56 +0100 > Krzysztof Kozlowski wrote: > > > On 05/12/2023 10:02, Andreas Kemnade wrote: > > > On Tue, 5 Dec 2023 09:45:44 +0100 > > > Krzysztof Kozlowski wrote: > > > > > >>> Sure the clock nodes can be there for the child IP, but

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-06 Thread H . Nikolaus Schaller
(non-html) > Am 06.12.2023 um 17:15 schrieb Andrew Davis : > > On 12/6/23 10:02 AM, Conor Dooley wrote: >> On Tue, Dec 05, 2023 at 07:04:05PM +0100, H. Nikolaus Schaller wrote: Am 05.12.2023 um 18:33 schrieb Andrew Davis : On 12/5/23 2:17 AM, H. Nikolaus Schaller wrote: >> +

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-06 Thread H. Nikolaus Schaller
> Am 06.12.2023 um 17:15 schrieb Andrew Davis : > > On 12/6/23 10:02 AM, Conor Dooley wrote: >> On Tue, Dec 05, 2023 at 07:04:05PM +0100, H. Nikolaus Schaller wrote: Am 05.12.2023 um 18:33 schrieb Andrew Davis : On 12/5/23 2:17 AM, H. Nikolaus Schaller wrote: >> + -

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-06 Thread H. Nikolaus Schaller
> Am 06.12.2023 um 17:02 schrieb Conor Dooley : > > On Tue, Dec 05, 2023 at 07:04:05PM +0100, H. Nikolaus Schaller wrote: >>> Am 05.12.2023 um 18:33 schrieb Andrew Davis : >>> >>> On 12/5/23 2:17 AM, H. Nikolaus Schaller wrote: > + - enum: > + - ti,omap3430-gpu #

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-06 Thread Andrew Davis
On 12/6/23 10:02 AM, Conor Dooley wrote: On Tue, Dec 05, 2023 at 07:04:05PM +0100, H. Nikolaus Schaller wrote: Am 05.12.2023 um 18:33 schrieb Andrew Davis : On 12/5/23 2:17 AM, H. Nikolaus Schaller wrote: + - enum: + - ti,omap3430-gpu # Rev 121 + -

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-06 Thread Conor Dooley
On Tue, Dec 05, 2023 at 07:04:05PM +0100, H. Nikolaus Schaller wrote: > > Am 05.12.2023 um 18:33 schrieb Andrew Davis : > > > > On 12/5/23 2:17 AM, H. Nikolaus Schaller wrote: > >>> + - enum: > >>> + - ti,omap3430-gpu # Rev 121 > >>> + - ti,omap3630-gpu # Rev

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread H. Nikolaus Schaller
> Am 05.12.2023 um 18:33 schrieb Andrew Davis : > > On 12/5/23 2:17 AM, H. Nikolaus Schaller wrote: >>> + - enum: >>> + - ti,omap3430-gpu # Rev 121 >>> + - ti,omap3630-gpu # Rev 125 >> Is the "Rev 121" and "Rev 125" a property of the SoC integration >>

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread Andrew Davis
On 12/5/23 2:17 AM, H. Nikolaus Schaller wrote: Hi Andrew, Am 04.12.2023 um 19:22 schrieb Andrew Davis : The Imagination PowerVR Series5 "SGX" GPU is part of several SoCs from multiple vendors. Great and thanks for the new attempt to get at least the Device Tree side upstream. Really

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread H. Nikolaus Schaller
Hi, > Am 05.12.2023 um 14:29 schrieb Maxime Ripard : > > Hi, > > On Tue, Dec 05, 2023 at 09:18:58AM +0100, H. Nikolaus Schaller wrote: >>> Am 05.12.2023 um 07:57 schrieb Maxime Ripard : >>> >>> On Mon, Dec 04, 2023 at 12:22:36PM -0600, Andrew Davis wrote: The Imagination PowerVR Series5

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread Maxime Ripard
Hi, On Tue, Dec 05, 2023 at 09:18:58AM +0100, H. Nikolaus Schaller wrote: > > Am 05.12.2023 um 07:57 schrieb Maxime Ripard : > > > > On Mon, Dec 04, 2023 at 12:22:36PM -0600, Andrew Davis wrote: > >> The Imagination PowerVR Series5 "SGX" GPU is part of several SoCs from > >> multiple vendors.

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread Andreas Kemnade
On Tue, 5 Dec 2023 09:45:44 +0100 Krzysztof Kozlowski wrote: > > Sure the clock nodes can be there for the child IP, but they won't do > > anything. And still need to be managed separately by the device driver if > > added. > > So if OS does not have runtime PM, the bindings are wrong?

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread Andreas Kemnade
On Tue, 5 Dec 2023 10:27:56 +0100 Krzysztof Kozlowski wrote: > On 05/12/2023 10:02, Andreas Kemnade wrote: > > On Tue, 5 Dec 2023 09:45:44 +0100 > > Krzysztof Kozlowski wrote: > > > >>> Sure the clock nodes can be there for the child IP, but they won't do > >>> anything. And still need to be

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread Krzysztof Kozlowski
On 05/12/2023 10:02, Andreas Kemnade wrote: > On Tue, 5 Dec 2023 09:45:44 +0100 > Krzysztof Kozlowski wrote: > >>> Sure the clock nodes can be there for the child IP, but they won't do >>> anything. And still need to be managed separately by the device driver if >>> added. >> >> So if OS does

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread Krzysztof Kozlowski
On 05/12/2023 09:30, Tony Lindgren wrote: > * Krzysztof Kozlowski [231205 08:16]: >> On 05/12/2023 09:10, Tony Lindgren wrote: >>> * Krzysztof Kozlowski [231205 08:03]: What does runtime PM have to do with it? If runtime PM enables clocks, these are real signals and not optional. >>>

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread Tony Lindgren
* Krzysztof Kozlowski [231205 08:16]: > On 05/12/2023 09:10, Tony Lindgren wrote: > > * Krzysztof Kozlowski [231205 08:03]: > >> What does runtime PM have to do with it? If runtime PM enables clocks, > >> these are real signals and not optional. > > > > Runtime PM propagates to the parent

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread H. Nikolaus Schaller
> Am 05.12.2023 um 07:57 schrieb Maxime Ripard : > > On Mon, Dec 04, 2023 at 12:22:36PM -0600, Andrew Davis wrote: >> The Imagination PowerVR Series5 "SGX" GPU is part of several SoCs from >> multiple vendors. Describe how the SGX GPU is integrated in these SoC, >> including register space and

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread H. Nikolaus Schaller
Hi Andrew, > Am 04.12.2023 um 19:22 schrieb Andrew Davis : > > The Imagination PowerVR Series5 "SGX" GPU is part of several SoCs from > multiple vendors. Great and thanks for the new attempt to get at least the Device Tree side upstream. Really appreciated! > Describe how the SGX GPU is

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread Krzysztof Kozlowski
On 05/12/2023 09:10, Tony Lindgren wrote: > * Krzysztof Kozlowski [231205 08:03]: >> What does runtime PM have to do with it? If runtime PM enables clocks, >> these are real signals and not optional. > > Runtime PM propagates to the parent device. Then it is not really relevant to the hardware

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread Tony Lindgren
* Krzysztof Kozlowski [231205 08:03]: > What does runtime PM have to do with it? If runtime PM enables clocks, > these are real signals and not optional. Runtime PM propagates to the parent device. Regards, Tony

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread Krzysztof Kozlowski
On 05/12/2023 08:56, Tony Lindgren wrote: > * Krzysztof Kozlowski [231205 07:10]: >> On 04/12/2023 19:22, Andrew Davis wrote: >>> @@ -56,6 +76,43 @@ allOf: >>>properties: >>> clocks: >>>maxItems: 1 >>> + required: >>> +- clocks >>> +- clock-names

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-04 Thread Tony Lindgren
* Krzysztof Kozlowski [231205 07:10]: > On 04/12/2023 19:22, Andrew Davis wrote: > > @@ -56,6 +76,43 @@ allOf: > >properties: > > clocks: > >maxItems: 1 > > + required: > > +- clocks > > +- clock-names > > You need to define the clocks for your

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-04 Thread Krzysztof Kozlowski
On 04/12/2023 19:22, Andrew Davis wrote: > The Imagination PowerVR Series5 "SGX" GPU is part of several SoCs from > multiple vendors. Describe how the SGX GPU is integrated in these SoC, > including register space and interrupts. Clocks, reset, and power domain > information is SoC specific. > >

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-04 Thread Maxime Ripard
On Mon, Dec 04, 2023 at 12:22:36PM -0600, Andrew Davis wrote: > The Imagination PowerVR Series5 "SGX" GPU is part of several SoCs from > multiple vendors. Describe how the SGX GPU is integrated in these SoC, > including register space and interrupts. Clocks, reset, and power domain > information

[PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-04 Thread Andrew Davis
The Imagination PowerVR Series5 "SGX" GPU is part of several SoCs from multiple vendors. Describe how the SGX GPU is integrated in these SoC, including register space and interrupts. Clocks, reset, and power domain information is SoC specific. Signed-off-by: Andrew Davis ---