Re: RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-06 Thread Neil Armstrong
On 06/07/2023 09:59, Maxime Ripard wrote: On Thu, Jul 06, 2023 at 09:33:15AM +0200, Neil Armstrong wrote: On 06/07/2023 09:24, Maxime Ripard wrote: On Wed, Jul 05, 2023 at 11:09:40PM +0300, Dmitry Baryshkov wrote: On 05/07/2023 19:53, Maxime Ripard wrote: On Wed, Jul 05, 2023 at 06:20:13PM +0

Re: RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-06 Thread Maxime Ripard
On Thu, Jul 06, 2023 at 09:33:15AM +0200, Neil Armstrong wrote: > On 06/07/2023 09:24, Maxime Ripard wrote: > > On Wed, Jul 05, 2023 at 11:09:40PM +0300, Dmitry Baryshkov wrote: > > > On 05/07/2023 19:53, Maxime Ripard wrote: > > > > On Wed, Jul 05, 2023 at 06:20:13PM +0300, Dmitry Baryshkov wrote:

Re: RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-06 Thread Neil Armstrong
On 06/07/2023 09:24, Maxime Ripard wrote: On Wed, Jul 05, 2023 at 11:09:40PM +0300, Dmitry Baryshkov wrote: On 05/07/2023 19:53, Maxime Ripard wrote: On Wed, Jul 05, 2023 at 06:20:13PM +0300, Dmitry Baryshkov wrote: On Wed, 5 Jul 2023 at 17:24, Maxime Ripard wrote: On Wed, Jul 05, 2023 at 0

Re: RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-06 Thread Maxime Ripard
On Wed, Jul 05, 2023 at 11:09:40PM +0300, Dmitry Baryshkov wrote: > On 05/07/2023 19:53, Maxime Ripard wrote: > > On Wed, Jul 05, 2023 at 06:20:13PM +0300, Dmitry Baryshkov wrote: > > > On Wed, 5 Jul 2023 at 17:24, Maxime Ripard wrote: > > > > > > > > On Wed, Jul 05, 2023 at 04:37:57PM +0300, Dmi

Re: RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-05 Thread Dmitry Baryshkov
On 05/07/2023 19:53, Maxime Ripard wrote: On Wed, Jul 05, 2023 at 06:20:13PM +0300, Dmitry Baryshkov wrote: On Wed, 5 Jul 2023 at 17:24, Maxime Ripard wrote: On Wed, Jul 05, 2023 at 04:37:57PM +0300, Dmitry Baryshkov wrote: Either way, I'm not really sure it's a good idea to multiply the ca

Re: RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-05 Thread Maxime Ripard
On Wed, Jul 05, 2023 at 06:20:13PM +0300, Dmitry Baryshkov wrote: > On Wed, 5 Jul 2023 at 17:24, Maxime Ripard wrote: > > > > On Wed, Jul 05, 2023 at 04:37:57PM +0300, Dmitry Baryshkov wrote: > > > > > > > > > > > > Either way, I'm not really sure it's a good idea to multiply the > > > > > > capab

Re: RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-05 Thread Neil Armstrong
On 05/07/2023 16:24, Maxime Ripard wrote: On Wed, Jul 05, 2023 at 04:37:57PM +0300, Dmitry Baryshkov wrote: Either way, I'm not really sure it's a good idea to multiply the capabilities flags of the DSI host, and we should just stick to the spec. If the spec says that we have to support DSC whi

Re: RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-05 Thread Dmitry Baryshkov
On Wed, 5 Jul 2023 at 17:24, Maxime Ripard wrote: > > On Wed, Jul 05, 2023 at 04:37:57PM +0300, Dmitry Baryshkov wrote: > > > > > > > > > > Either way, I'm not really sure it's a good idea to multiply the > > > > > capabilities flags of the DSI host, and we should just stick to the > > > > > spec.

Re: RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-05 Thread Maxime Ripard
On Wed, Jul 05, 2023 at 04:37:57PM +0300, Dmitry Baryshkov wrote: > > > > > > > > Either way, I'm not really sure it's a good idea to multiply the > > > > capabilities flags of the DSI host, and we should just stick to the > > > > spec. If the spec says that we have to support DSC while video is >

Re: RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-05 Thread Dmitry Baryshkov
On 05/07/2023 16:29, Maxime Ripard wrote: On Wed, Jul 05, 2023 at 03:05:33PM +0200, Neil Armstrong wrote: On 05/07/2023 14:04, Maxime Ripard wrote: Hi, On Tue, May 30, 2023 at 03:36:04PM +0300, Dmitry Baryshkov wrote: On 30/05/2023 15:15, AngeloGioacchino Del Regno wrote: Il 30/05/23 13:44,

Re: RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-05 Thread Maxime Ripard
On Wed, Jul 05, 2023 at 03:05:33PM +0200, Neil Armstrong wrote: > On 05/07/2023 14:04, Maxime Ripard wrote: > > Hi, > > > > On Tue, May 30, 2023 at 03:36:04PM +0300, Dmitry Baryshkov wrote: > > > On 30/05/2023 15:15, AngeloGioacchino Del Regno wrote: > > > > Il 30/05/23 13:44, Dmitry Baryshkov ha

Re: RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-05 Thread Neil Armstrong
On 05/07/2023 14:04, Maxime Ripard wrote: Hi, On Tue, May 30, 2023 at 03:36:04PM +0300, Dmitry Baryshkov wrote: On 30/05/2023 15:15, AngeloGioacchino Del Regno wrote: Il 30/05/23 13:44, Dmitry Baryshkov ha scritto: On Tue, 30 May 2023 at 10:24, Neil Armstrong wrote: Hi Marijn, Dmitry, Cale

Re: RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-05 Thread Maxime Ripard
Hi, On Tue, May 30, 2023 at 03:36:04PM +0300, Dmitry Baryshkov wrote: > On 30/05/2023 15:15, AngeloGioacchino Del Regno wrote: > > Il 30/05/23 13:44, Dmitry Baryshkov ha scritto: > > > On Tue, 30 May 2023 at 10:24, Neil Armstrong > > > wrote: > > > > > > > > Hi Marijn, Dmitry, Caleb, Jessica, >

Re: RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-05-31 Thread AngeloGioacchino Del Regno
Il 30/05/23 17:44, Neil Armstrong ha scritto: On 30/05/2023 14:36, Dmitry Baryshkov wrote: On 30/05/2023 15:15, AngeloGioacchino Del Regno wrote: Il 30/05/23 13:44, Dmitry Baryshkov ha scritto: On Tue, 30 May 2023 at 10:24, Neil Armstrong wrote: Hi Marijn, Dmitry, Caleb, Jessica, On 29/05/

Re: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3

2023-05-30 Thread Dmitry Baryshkov
On 30/05/2023 21:13, Marijn Suijten wrote: On 2023-05-30 10:54:17, Abhinav Kumar wrote: On 30/05/2023 00:07, Marijn Suijten wrote: On 2023-05-22 15:58:56, Dmitry Baryshkov wrote: On Mon, 22 May 2023 at 12:04, Neil Armstrong wrote: On 22/05/2023 03:16, Dmitry Baryshkov wrote: On 22/05/2023

Re: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3

2023-05-30 Thread Marijn Suijten
On 2023-05-30 14:11:06, Dmitry Baryshkov wrote: > On Tue, 30 May 2023 at 11:27, Marijn Suijten > wrote: > > > > On 2023-05-30 01:39:10, Dmitry Baryshkov wrote: > > > On 30/05/2023 01:37, Marijn Suijten wrote: > > > > On 2023-05-30 01:18:40, Dmitry Baryshkov wrote: > > > > > > > >>> +ret =

Re: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3

2023-05-30 Thread Marijn Suijten
On 2023-05-30 10:54:17, Abhinav Kumar wrote: > > On 30/05/2023 00:07, Marijn Suijten wrote: > >> On 2023-05-22 15:58:56, Dmitry Baryshkov wrote: > >>> On Mon, 22 May 2023 at 12:04, Neil Armstrong > >>> wrote: > > On 22/05/2023 03:16, Dmitry Baryshkov wrote: > > On 22/05/2023 00:23,

Re: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3

2023-05-30 Thread Abhinav Kumar
On 5/29/2023 3:18 PM, Dmitry Baryshkov wrote: On 30/05/2023 00:07, Marijn Suijten wrote: On 2023-05-22 15:58:56, Dmitry Baryshkov wrote: On Mon, 22 May 2023 at 12:04, Neil Armstrong wrote: On 22/05/2023 03:16, Dmitry Baryshkov wrote: On 22/05/2023 00:23, Marijn Suijten wrote: Sony provid

Re: RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-05-30 Thread Neil Armstrong
On 30/05/2023 14:36, Dmitry Baryshkov wrote: On 30/05/2023 15:15, AngeloGioacchino Del Regno wrote: Il 30/05/23 13:44, Dmitry Baryshkov ha scritto: On Tue, 30 May 2023 at 10:24, Neil Armstrong wrote: Hi Marijn, Dmitry, Caleb, Jessica, On 29/05/2023 23:11, Marijn Suijten wrote: On 2023-05-2

Re: RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-05-30 Thread Dmitry Baryshkov
On 30/05/2023 15:15, AngeloGioacchino Del Regno wrote: Il 30/05/23 13:44, Dmitry Baryshkov ha scritto: On Tue, 30 May 2023 at 10:24, Neil Armstrong wrote: Hi Marijn, Dmitry, Caleb, Jessica, On 29/05/2023 23:11, Marijn Suijten wrote: On 2023-05-22 04:16:20, Dmitry Baryshkov wrote: +   if (

Re: RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-05-30 Thread AngeloGioacchino Del Regno
Il 30/05/23 13:44, Dmitry Baryshkov ha scritto: On Tue, 30 May 2023 at 10:24, Neil Armstrong wrote: Hi Marijn, Dmitry, Caleb, Jessica, On 29/05/2023 23:11, Marijn Suijten wrote: On 2023-05-22 04:16:20, Dmitry Baryshkov wrote: + if (ctx->dsi->dsc) { dsi->dsc is always set, thus this con

RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-05-30 Thread Dmitry Baryshkov
On Tue, 30 May 2023 at 10:24, Neil Armstrong wrote: > > Hi Marijn, Dmitry, Caleb, Jessica, > > On 29/05/2023 23:11, Marijn Suijten wrote: > > On 2023-05-22 04:16:20, Dmitry Baryshkov wrote: > > > >>> + if (ctx->dsi->dsc) { > >> > >> dsi->dsc is always set, thus this condition can be dropped. >

Re: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3

2023-05-30 Thread Dmitry Baryshkov
On Tue, 30 May 2023 at 11:27, Marijn Suijten wrote: > > On 2023-05-30 01:39:10, Dmitry Baryshkov wrote: > > On 30/05/2023 01:37, Marijn Suijten wrote: > > > On 2023-05-30 01:18:40, Dmitry Baryshkov wrote: > > > > > >>> +ret = mipi_dsi_dcs_set_display_on(dsi); > > >>> +if (ret < 0)

Re: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3

2023-05-30 Thread Konrad Dybcio
On 30.05.2023 10:41, Marijn Suijten wrote: > On 2023-05-30 09:24:24, Neil Armstrong wrote: >> Hi Marijn, Dmitry, Caleb, Jessica, >> >> On 29/05/2023 23:11, Marijn Suijten wrote: >>> On 2023-05-22 04:16:20, Dmitry Baryshkov wrote: >>> > + if (ctx->dsi->dsc) { dsi->dsc is always set

Re: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3

2023-05-30 Thread Marijn Suijten
On 2023-05-30 09:24:24, Neil Armstrong wrote: > Hi Marijn, Dmitry, Caleb, Jessica, > > On 29/05/2023 23:11, Marijn Suijten wrote: > > On 2023-05-22 04:16:20, Dmitry Baryshkov wrote: > > > >>> + if (ctx->dsi->dsc) { > >> > >> dsi->dsc is always set, thus this condition can be dropped. > > > > I w

Re: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3

2023-05-30 Thread Marijn Suijten
On 2023-05-30 01:39:10, Dmitry Baryshkov wrote: > On 30/05/2023 01:37, Marijn Suijten wrote: > > On 2023-05-30 01:18:40, Dmitry Baryshkov wrote: > > > >>> +ret = mipi_dsi_dcs_set_display_on(dsi); > >>> +if (ret < 0) { > >>> +dev_err(dev, "Failed to turn display on: %d\n

Re: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3

2023-05-30 Thread Neil Armstrong
Hi Marijn, Dmitry, Caleb, Jessica, On 29/05/2023 23:11, Marijn Suijten wrote: On 2023-05-22 04:16:20, Dmitry Baryshkov wrote: + if (ctx->dsi->dsc) { dsi->dsc is always set, thus this condition can be dropped. I want to leave room for possibly running the panel without DSC (at a lower

Re: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3

2023-05-29 Thread Dmitry Baryshkov
On 30/05/2023 01:37, Marijn Suijten wrote: On 2023-05-30 01:18:40, Dmitry Baryshkov wrote: +ret = mipi_dsi_dcs_set_display_on(dsi); +if (ret < 0) { +dev_err(dev, "Failed to turn display on: %d\n", ret); +return ret; +} My usual question: should the mipi_dsi_dcs_exi

Re: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3

2023-05-29 Thread Marijn Suijten
On 2023-05-30 01:18:40, Dmitry Baryshkov wrote: > > +ret = mipi_dsi_dcs_set_display_on(dsi); > > +if (ret < 0) { > > +dev_err(dev, "Failed to turn display on: %d\n", ret); > > +return ret; > > +} > > My usual question: should the mipi_dsi_d

Re: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3

2023-05-29 Thread Dmitry Baryshkov
On 30/05/2023 00:11, Marijn Suijten wrote: On 2023-05-22 04:16:20, Dmitry Baryshkov wrote: + if (ctx->dsi->dsc) { dsi->dsc is always set, thus this condition can be dropped. I want to leave room for possibly running the panel without DSC (at a lower resolution/refresh rate, or at high

Re: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3

2023-05-29 Thread Dmitry Baryshkov
On 30/05/2023 00:07, Marijn Suijten wrote: On 2023-05-22 15:58:56, Dmitry Baryshkov wrote: On Mon, 22 May 2023 at 12:04, Neil Armstrong wrote: On 22/05/2023 03:16, Dmitry Baryshkov wrote: On 22/05/2023 00:23, Marijn Suijten wrote: Sony provides an unlabeled LGD + Atmel maXTouch assembly in

Re: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3

2023-05-29 Thread Dmitry Baryshkov
On 30/05/2023 00:11, Marijn Suijten wrote: On 2023-05-22 04:16:20, Dmitry Baryshkov wrote: + if (ctx->dsi->dsc) { dsi->dsc is always set, thus this condition can be dropped. I want to leave room for possibly running the panel without DSC (at a lower resolution/refresh rate, or at high

Re: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3

2023-05-29 Thread Marijn Suijten
On 2023-05-22 04:16:20, Dmitry Baryshkov wrote: > > + if (ctx->dsi->dsc) { > > dsi->dsc is always set, thus this condition can be dropped. I want to leave room for possibly running the panel without DSC (at a lower resolution/refresh rate, or at higher power consumption if there is enough BW)

Re: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3

2023-05-29 Thread Marijn Suijten
On 2023-05-22 15:58:56, Dmitry Baryshkov wrote: > On Mon, 22 May 2023 at 12:04, Neil Armstrong > wrote: > > > > On 22/05/2023 03:16, Dmitry Baryshkov wrote: > > > On 22/05/2023 00:23, Marijn Suijten wrote: > > >> Sony provides an unlabeled LGD + Atmel maXTouch assembly in its Xperia > > >> XZ3 (t

Re: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3

2023-05-22 Thread Dmitry Baryshkov
On Mon, 22 May 2023 at 12:04, Neil Armstrong wrote: > > On 22/05/2023 03:16, Dmitry Baryshkov wrote: > > On 22/05/2023 00:23, Marijn Suijten wrote: > >> Sony provides an unlabeled LGD + Atmel maXTouch assembly in its Xperia > >> XZ3 (tama akatsuki) phone, with custom DCS commands to match. > >> >

Re: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3

2023-05-22 Thread Neil Armstrong
On 22/05/2023 03:16, Dmitry Baryshkov wrote: On 22/05/2023 00:23, Marijn Suijten wrote: Sony provides an unlabeled LGD + Atmel maXTouch assembly in its Xperia XZ3 (tama akatsuki) phone, with custom DCS commands to match. This panel features Display Stream Compression 1.1. Signed-off-by: Marijn

Re: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3

2023-05-21 Thread Dmitry Baryshkov
On 22/05/2023 00:23, Marijn Suijten wrote: Sony provides an unlabeled LGD + Atmel maXTouch assembly in its Xperia XZ3 (tama akatsuki) phone, with custom DCS commands to match. This panel features Display Stream Compression 1.1. Signed-off-by: Marijn Suijten --- drivers/gpu/drm/panel/Kconfig

[PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3

2023-05-21 Thread Marijn Suijten
Sony provides an unlabeled LGD + Atmel maXTouch assembly in its Xperia XZ3 (tama akatsuki) phone, with custom DCS commands to match. This panel features Display Stream Compression 1.1. Signed-off-by: Marijn Suijten --- drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/pan