Re: [PATCH RFC 3/6] drm: Plane YCbCr to RGB conversion related properties

2017-05-02 Thread Jyri Sarha
On 05/02/17 11:33, Daniel Vetter wrote: > On Fri, Apr 21, 2017 at 12:51:14PM +0300, Jyri Sarha wrote: >> Add standard properties to control YCbCr to RGB conversion in DRM >> planes. The created properties are stored to drm_plane object to allow >> different set of supported conversion modes for

Re: [PATCH RFC 3/6] drm: Plane YCbCr to RGB conversion related properties

2017-05-02 Thread Daniel Vetter
On Fri, Apr 21, 2017 at 12:51:14PM +0300, Jyri Sarha wrote: > Add standard properties to control YCbCr to RGB conversion in DRM > planes. The created properties are stored to drm_plane object to allow > different set of supported conversion modes for different planes on > the device. For

Re: [PATCH RFC 3/6] drm: Plane YCbCr to RGB conversion related properties

2017-04-26 Thread Ville Syrjälä
On Wed, Apr 26, 2017 at 03:56:54PM +0300, Jyri Sarha wrote: > On 04/24/17 19:55, Ville Syrjälä wrote: > >> In fact we have plane specific YCbCr to RGB CSC (only preoffset > >> possible), then (per crtc) gamma table, and finally a (per crtc) RGB to > >> YCbCr CSC with optional post offset (so it

Re: [PATCH RFC 3/6] drm: Plane YCbCr to RGB conversion related properties

2017-04-26 Thread Sharma, Shashank
Regards Shashank On 4/26/2017 6:26 PM, Jyri Sarha wrote: On 04/24/17 19:55, Ville Syrjälä wrote: In fact we have plane specific YCbCr to RGB CSC (only preoffset possible), then (per crtc) gamma table, and finally a (per crtc) RGB to YCbCr CSC with optional post offset (so it can be used

Re: [PATCH RFC 3/6] drm: Plane YCbCr to RGB conversion related properties

2017-04-26 Thread Jyri Sarha
On 04/24/17 19:55, Ville Syrjälä wrote: >> In fact we have plane specific YCbCr to RGB CSC (only preoffset >> possible), then (per crtc) gamma table, and finally a (per crtc) RGB to >> YCbCr CSC with optional post offset (so it can be used either as CSC or >> CTM). > So with that plane hw you

Re: [PATCH RFC 3/6] drm: Plane YCbCr to RGB conversion related properties

2017-04-24 Thread Ville Syrjälä
On Mon, Apr 24, 2017 at 06:49:04PM +0300, Jyri Sarha wrote: > On 04/24/17 18:13, Ville Syrjälä wrote: > >> What about the uapi structs? In the patch there is an explicit struct > >> naming each coefficient for what they are for in YCbCr to RGB > >> conversion. Is this Ok, or should we go with a

Re: [PATCH RFC 3/6] drm: Plane YCbCr to RGB conversion related properties

2017-04-24 Thread Jyri Sarha
On 04/24/17 18:13, Ville Syrjälä wrote: >> What about the uapi structs? In the patch there is an explicit struct >> naming each coefficient for what they are for in YCbCr to RGB >> conversion. Is this Ok, or should we go with a generic (CTM style) >> matrix, that could be used for RGB to YCbCr

Re: [PATCH RFC 3/6] drm: Plane YCbCr to RGB conversion related properties

2017-04-24 Thread Ville Syrjälä
On Mon, Apr 24, 2017 at 04:21:39PM +0300, Jyri Sarha wrote: > On 04/21/17 16:52, Ville Syrjälä wrote: > > On Fri, Apr 21, 2017 at 04:39:16PM +0300, Jyri Sarha wrote: > >> On 04/21/17 14:17, Ville Syrjälä wrote: > +static char *ycbcr_to_rgb_mode_name[] = { > +

Re: [PATCH RFC 3/6] drm: Plane YCbCr to RGB conversion related properties

2017-04-24 Thread Jyri Sarha
On 04/21/17 16:52, Ville Syrjälä wrote: > On Fri, Apr 21, 2017 at 04:39:16PM +0300, Jyri Sarha wrote: >> On 04/21/17 14:17, Ville Syrjälä wrote: +static char *ycbcr_to_rgb_mode_name[] = { + [DRM_PLANE_YCBCR_BT601_LIM_TO_RGB_BT601_FULL] = + "YCbCr BT.601 limited range TO

Re: [PATCH RFC 3/6] drm: Plane YCbCr to RGB conversion related properties

2017-04-24 Thread Brian Starkey
On Fri, Apr 21, 2017 at 07:49:04PM +0300, Ville Syrjälä wrote: On Fri, Apr 21, 2017 at 04:34:00PM +0100, Brian Starkey wrote: On Fri, Apr 21, 2017 at 06:21:48PM +0300, Ville Syrjälä wrote: >On Fri, Apr 21, 2017 at 03:53:42PM +0100, Brian Starkey wrote: >> Hi, >> >> Thanks for picking this up

Re: [PATCH RFC 3/6] drm: Plane YCbCr to RGB conversion related properties

2017-04-21 Thread Ville Syrjälä
On Fri, Apr 21, 2017 at 04:34:00PM +0100, Brian Starkey wrote: > On Fri, Apr 21, 2017 at 06:21:48PM +0300, Ville Syrjälä wrote: > >On Fri, Apr 21, 2017 at 03:53:42PM +0100, Brian Starkey wrote: > >> Hi, > >> > >> Thanks for picking this up Jyri. > >> > >> On Fri, Apr 21, 2017 at 04:52:03PM +0300,

Re: [PATCH RFC 3/6] drm: Plane YCbCr to RGB conversion related properties

2017-04-21 Thread Brian Starkey
On Fri, Apr 21, 2017 at 06:21:48PM +0300, Ville Syrjälä wrote: On Fri, Apr 21, 2017 at 03:53:42PM +0100, Brian Starkey wrote: Hi, Thanks for picking this up Jyri. On Fri, Apr 21, 2017 at 04:52:03PM +0300, Ville Syrjälä wrote: >On Fri, Apr 21, 2017 at 04:39:16PM +0300, Jyri Sarha wrote: >> On

Re: [PATCH RFC 3/6] drm: Plane YCbCr to RGB conversion related properties

2017-04-21 Thread Ville Syrjälä
On Fri, Apr 21, 2017 at 03:53:42PM +0100, Brian Starkey wrote: > Hi, > > Thanks for picking this up Jyri. > > On Fri, Apr 21, 2017 at 04:52:03PM +0300, Ville Syrjälä wrote: > >On Fri, Apr 21, 2017 at 04:39:16PM +0300, Jyri Sarha wrote: > >> On 04/21/17 14:17, Ville Syrjälä wrote: > >> >> +static

Re: [PATCH RFC 3/6] drm: Plane YCbCr to RGB conversion related properties

2017-04-21 Thread Brian Starkey
Hi, Thanks for picking this up Jyri. On Fri, Apr 21, 2017 at 04:52:03PM +0300, Ville Syrjälä wrote: On Fri, Apr 21, 2017 at 04:39:16PM +0300, Jyri Sarha wrote: On 04/21/17 14:17, Ville Syrjälä wrote: >> +static char *ycbcr_to_rgb_mode_name[] = { >> +

Re: [PATCH RFC 3/6] drm: Plane YCbCr to RGB conversion related properties

2017-04-21 Thread Ville Syrjälä
On Fri, Apr 21, 2017 at 04:39:16PM +0300, Jyri Sarha wrote: > On 04/21/17 14:17, Ville Syrjälä wrote: > >> +static char *ycbcr_to_rgb_mode_name[] = { > >> + [DRM_PLANE_YCBCR_BT601_LIM_TO_RGB_BT601_FULL] = > >> + "YCbCr BT.601 limited range TO RGB BT.601 full range", > >> +

Re: [PATCH RFC 3/6] drm: Plane YCbCr to RGB conversion related properties

2017-04-21 Thread Jyri Sarha
On 04/21/17 14:17, Ville Syrjälä wrote: >> +static char *ycbcr_to_rgb_mode_name[] = { >> +[DRM_PLANE_YCBCR_BT601_LIM_TO_RGB_BT601_FULL] = >> +"YCbCr BT.601 limited range TO RGB BT.601 full range", >> +[DRM_PLANE_YCBCR_BT601_FULL_TO_RGB_BT601_FULL] = >> +"YCbCr

Re: [PATCH RFC 3/6] drm: Plane YCbCr to RGB conversion related properties

2017-04-21 Thread Ville Syrjälä
On Fri, Apr 21, 2017 at 03:10:31PM +0300, Laurent Pinchart wrote: > Hello, > > CC'ing Hans Verkuil for his knowledge on colorspace. > > On Friday 21 Apr 2017 14:17:56 Ville Syrjälä wrote: > > On Fri, Apr 21, 2017 at 12:51:14PM +0300, Jyri Sarha wrote: > > > Add standard properties to control

Re: [PATCH RFC 3/6] drm: Plane YCbCr to RGB conversion related properties

2017-04-21 Thread Sharma, Shashank
Regards Shashank On 4/21/2017 4:47 PM, Ville Syrjälä wrote: On Fri, Apr 21, 2017 at 12:51:14PM +0300, Jyri Sarha wrote: Add standard properties to control YCbCr to RGB conversion in DRM planes. The created properties are stored to drm_plane object to allow different set of supported

Re: [PATCH RFC 3/6] drm: Plane YCbCr to RGB conversion related properties

2017-04-21 Thread Laurent Pinchart
Hello, CC'ing Hans Verkuil for his knowledge on colorspace. On Friday 21 Apr 2017 14:17:56 Ville Syrjälä wrote: > On Fri, Apr 21, 2017 at 12:51:14PM +0300, Jyri Sarha wrote: > > Add standard properties to control YCbCr to RGB conversion in DRM > > planes. The created properties are stored to

Re: [PATCH RFC 3/6] drm: Plane YCbCr to RGB conversion related properties

2017-04-21 Thread Ville Syrjälä
On Fri, Apr 21, 2017 at 12:51:14PM +0300, Jyri Sarha wrote: > Add standard properties to control YCbCr to RGB conversion in DRM > planes. The created properties are stored to drm_plane object to allow > different set of supported conversion modes for different planes on > the device. For

[PATCH RFC 3/6] drm: Plane YCbCr to RGB conversion related properties

2017-04-21 Thread Jyri Sarha
Add standard properties to control YCbCr to RGB conversion in DRM planes. The created properties are stored to drm_plane object to allow different set of supported conversion modes for different planes on the device. For simplicity the related property blobs for CSC matrix and YCbCr preoffsets are