Re: [PATCH V2 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-04-30 Thread Neil Armstrong
On 29/04/2021 18:27, Frieder Schrempf wrote: > On 28.04.21 16:16, Marek Vasut wrote: >> On 4/28/21 11:24 AM, Neil Armstrong wrote: >> [...] >> >>> +static int sn65dsi83_probe(struct i2c_client *client, >>> +   const struct i2c_device_id *id) >>> +{ >>> +    struct device

Re: [PATCH V2 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-04-29 Thread Frieder Schrempf
On 28.04.21 16:16, Marek Vasut wrote: On 4/28/21 11:24 AM, Neil Armstrong wrote: [...] +static int sn65dsi83_probe(struct i2c_client *client, +   const struct i2c_device_id *id) +{ +    struct device *dev = &client->dev; +    enum sn65dsi83_model model; +    struct sn65dsi83 *ctx; +

Re: [PATCH V2 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-04-28 Thread Marek Vasut
On 4/28/21 11:49 AM, Jagan Teki wrote: [...] I just saw the note in the header of the driver that says that single link mode is unsupported for the DSI84. I have hardware with a single link display and if I set ctx->lvds_dual_link = false it works just fine. How is this supposed to be selected

Re: [PATCH V2 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-04-28 Thread Marek Vasut
On 4/28/21 11:24 AM, Neil Armstrong wrote: [...] +static int sn65dsi83_probe(struct i2c_client *client, + const struct i2c_device_id *id) +{ +struct device *dev = &client->dev; +enum sn65dsi83_model model; +struct sn65dsi83 *ctx; +int ret; + +ctx = devm_kzalloc(

Re: [PATCH V2 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-04-28 Thread Jagan Teki
On Wed, Apr 28, 2021 at 2:54 PM Neil Armstrong wrote: > > On 28/04/2021 11:26, Loic Poulain wrote: > > On Wed, 28 Apr 2021 at 10:13, Frieder Schrempf > > wrote: > >> > >> On 28.04.21 09:51, Frieder Schrempf wrote: > >>> On 22.04.21 00:31, Marek Vasut wrote: > Add driver for TI SN65DSI83 Sing

Re: [PATCH V2 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-04-28 Thread Neil Armstrong
On 28/04/2021 11:26, Loic Poulain wrote: > On Wed, 28 Apr 2021 at 10:13, Frieder Schrempf > wrote: >> >> On 28.04.21 09:51, Frieder Schrempf wrote: >>> On 22.04.21 00:31, Marek Vasut wrote: Add driver for TI SN65DSI83 Single-link DSI to Single-link LVDS bridge and TI SN65DSI84 Single-lin

Re: [PATCH V2 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-04-28 Thread Loic Poulain
On Wed, 28 Apr 2021 at 10:13, Frieder Schrempf wrote: > > On 28.04.21 09:51, Frieder Schrempf wrote: > > On 22.04.21 00:31, Marek Vasut wrote: > >> Add driver for TI SN65DSI83 Single-link DSI to Single-link LVDS bridge > >> and TI SN65DSI84 Single-link DSI to Dual-link or 2x Single-link LVDS > >>

Re: [PATCH V2 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-04-28 Thread Frieder Schrempf
On 28.04.21 09:51, Frieder Schrempf wrote: On 22.04.21 00:31, Marek Vasut wrote: Add driver for TI SN65DSI83 Single-link DSI to Single-link LVDS bridge and TI SN65DSI84 Single-link DSI to Dual-link or 2x Single-link LVDS bridge. TI SN65DSI85 is unsupported due to lack of hardware to test on, but

Re: [PATCH V2 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-04-28 Thread Frieder Schrempf
On 22.04.21 00:31, Marek Vasut wrote: Add driver for TI SN65DSI83 Single-link DSI to Single-link LVDS bridge and TI SN65DSI84 Single-link DSI to Dual-link or 2x Single-link LVDS bridge. TI SN65DSI85 is unsupported due to lack of hardware to test on, but easy to add. The driver operates the chip

Re: [PATCH V2 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-04-27 Thread Felix Radensky
 Hi Marek, SN65DSI84 also supports single-link LVDS. We have quite a few customers using SN65DSI84 on Variscite SOMs with low resolution single-channel LVDS panels. I think having a DTS binding to indicate the number of links used by SN65DSI84 is more flexible than forcing dual-link mode on all

Re: [PATCH V2 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-04-23 Thread Loic Poulain
On 22/04/2021 00:31, Marek Vasut wrote: Add driver for TI SN65DSI83 Single-link DSI to Single-link LVDS bridge and TI SN65DSI84 Single-link DSI to Dual-link or 2x Single-link LVDS bridge. TI SN65DSI85 is unsupported due to lack of hardware to test on, but easy to add. The driver operates the

[PATCH V2 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-04-21 Thread Marek Vasut
Add driver for TI SN65DSI83 Single-link DSI to Single-link LVDS bridge and TI SN65DSI84 Single-link DSI to Dual-link or 2x Single-link LVDS bridge. TI SN65DSI85 is unsupported due to lack of hardware to test on, but easy to add. The driver operates the chip via I2C bus. Currently the LVDS clock ar