[PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-29 Thread Rob Clark
On Mon, Apr 28, 2014 at 9:08 AM, Ajay kumar wrote: > Daniel, > > On Sun, Apr 27, 2014 at 6:25 PM, Daniel Vetter wrote: >> On Fri, Apr 25, 2014 at 8:17 AM, Ajay kumar wrote: >>> We can call panel_enable/disable at the right point. Even the bridge chips >>> expect the same. So, I am not ok with

[PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-28 Thread Ajay kumar
Daniel, On Sun, Apr 27, 2014 at 6:25 PM, Daniel Vetter wrote: > On Fri, Apr 25, 2014 at 8:17 AM, Ajay kumar wrote: >> We can call panel_enable/disable at the right point. Even the bridge chips >> expect the same. So, I am not ok with combining the bridge and panel and >> calling the fxn

[PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-27 Thread Daniel Vetter
On Fri, Apr 25, 2014 at 8:17 AM, Ajay kumar wrote: > We can call panel_enable/disable at the right point. Even the bridge chips > expect the same. So, I am not ok with combining the bridge and panel and > calling the fxn pointers from crtc_helpers. > So, either we leave it the way it is in this

[PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-25 Thread Ajay kumar
Sorry for the previous reply. Here goes the full explaination. On Fri, Apr 25, 2014 at 11:40 AM, Ajay kumar wrote: > On Thu, Apr 24, 2014 at 11:08 PM, Ajay kumar wrote: >> On Thu, Apr 24, 2014 at 10:55 PM, Rob Clark wrote: >>> On Thu, Apr 24, 2014 at 12:55 PM, Ajay kumar wrote: Rob,

[PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-25 Thread Ajay kumar
On Thu, Apr 24, 2014 at 11:08 PM, Ajay kumar wrote: > On Thu, Apr 24, 2014 at 10:55 PM, Rob Clark wrote: >> On Thu, Apr 24, 2014 at 12:55 PM, Ajay kumar wrote: >>> Rob, >>> >>> On Thu, Apr 24, 2014 at 9:41 PM, Rob Clark wrote: On Wed, Apr 23, 2014 at 3:02 PM, Ajay kumar wrote: >

[PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-25 Thread Ajay kumar
On Thu, Apr 24, 2014 at 10:55 PM, Rob Clark wrote: > On Thu, Apr 24, 2014 at 12:55 PM, Ajay kumar wrote: >> Rob, >> >> On Thu, Apr 24, 2014 at 9:41 PM, Rob Clark wrote: >>> On Wed, Apr 23, 2014 at 3:02 PM, Ajay kumar wrote: Sorry for the previous reply, Here goes the full

[PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-24 Thread Ajay kumar
Rob, On Thu, Apr 24, 2014 at 9:41 PM, Rob Clark wrote: > On Wed, Apr 23, 2014 at 3:02 PM, Ajay kumar wrote: >> Sorry for the previous reply, >> >> Here goes the full explaination: >> >>> Rob, >>> >>> On Tue, Apr 22, 2014 at 5:04 PM, Rob Clark wrote: So what about, rather than adding

[PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-24 Thread Rob Clark
On Thu, Apr 24, 2014 at 12:55 PM, Ajay kumar wrote: > Rob, > > On Thu, Apr 24, 2014 at 9:41 PM, Rob Clark wrote: >> On Wed, Apr 23, 2014 at 3:02 PM, Ajay kumar wrote: >>> Sorry for the previous reply, >>> >>> Here goes the full explaination: >>> Rob, On Tue, Apr 22, 2014 at 5:04

[PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-24 Thread Rob Clark
On Wed, Apr 23, 2014 at 3:02 PM, Ajay kumar wrote: > Sorry for the previous reply, > > Here goes the full explaination: > >> Rob, >> >> On Tue, Apr 22, 2014 at 5:04 PM, Rob Clark wrote: >>> So what about, rather than adding drm_panel support to each bridge >>> individually, we introduce a

[PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-24 Thread Ajay kumar
Sorry for the previous reply, Here goes the full explaination: > Rob, > > On Tue, Apr 22, 2014 at 5:04 PM, Rob Clark wrote: >> So what about, rather than adding drm_panel support to each bridge >> individually, we introduce a drm_panel_bridge (with a form of >> chaining).. ie: >> >> struct

[PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-24 Thread Ajay kumar
Rob, On Tue, Apr 22, 2014 at 5:04 PM, Rob Clark wrote: > So what about, rather than adding drm_panel support to each bridge > individually, we introduce a drm_panel_bridge (with a form of > chaining).. ie: > > struct drm_panel_bridge { > struct drm_bridge base; > struct drm_panel

[PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-22 Thread Daniel Vetter
On Tue, Apr 22, 2014 at 07:34:03AM -0400, Rob Clark wrote: > So what about, rather than adding drm_panel support to each bridge > individually, we introduce a drm_panel_bridge (with a form of > chaining).. ie: > > struct drm_panel_bridge { > struct drm_bridge base; > struct drm_panel

[PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-22 Thread Thierry Reding
On Tue, Apr 22, 2014 at 04:09:16AM +0530, Ajay Kumar wrote: [...] > diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c > b/drivers/gpu/drm/exynos/exynos_dp_core.c [...] > @@ -1012,9 +1013,16 @@ static int exynos_dp_create_connector(struct > exynos_drm_display *display, > dp->encoder =

[PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-22 Thread Rob Clark
So what about, rather than adding drm_panel support to each bridge individually, we introduce a drm_panel_bridge (with a form of chaining).. ie: struct drm_panel_bridge { struct drm_bridge base; struct drm_panel *panel; struct drm_bridge *bridge; /* optional */ }; static void

[PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-22 Thread Ajay Kumar
attach ptn3460 connector to drm_panel and support drm_panel routines, if a valid drm_panel object is passed to ptn3460_init. Signed-off-by: Ajay Kumar --- Changes since V1: Address few coding style comments from Jingoo Han drivers/gpu/drm/bridge/Kconfig |1 +