Re: [PATCH V3 1/2] drm/exynos: add platform_device_id table and driver data for exynos5 drm fimd

2012-09-06 Thread Tomasz Figa
Hi Leela, See my comments inline. On Thursday 16 of August 2012 12:08:08 Leela Krishna Amudala wrote: +enum fimd_version_type { + VERSION_8, /* FIMD_VERSION8 */ +}; + +struct drm_fimd_driver_data { + enum fimd_version_type fimd_ver; +}; + +struct drm_fimd_driver_data

Re: Re: [PATCH V3 1/2] drm/exynos: add platform_device_id table and driver data for exynos5 drm fimd

2012-09-06 Thread Leela Krishna Amudala
: Re: [PATCH V3 1/2] drm/exynos: add platform_device_id table and driver data for exynos5 drm fimd Hi Leela, See my comments inline. On Thursday 16 of August 2012 12:08:08 Leela Krishna Amudala wrote: +enum fimd_version_type { + VERSION_8, /* FIMD_VERSION8 */ +}; + +struct

[PATCH V3 1/2] drm/exynos: add platform_device_id table and driver data for exynos5 drm fimd

2012-09-05 Thread Tomasz Figa
Hi Leela, See my comments inline. On Thursday 16 of August 2012 12:08:08 Leela Krishna Amudala wrote: > +enum fimd_version_type { > + VERSION_8, /* FIMD_VERSION8 */ > +}; > + > +struct drm_fimd_driver_data { > + enum fimd_version_type fimd_ver; > +}; > + > +struct drm_fimd_driver_data

[PATCH V3 1/2] drm/exynos: add platform_device_id table and driver data for exynos5 drm fimd

2012-09-05 Thread Leela Krishna Amudala
/2] drm/exynos: add platform_device_id table and driver data for exynos5 drm fimd Hi Leela, See my comments inline. On Thursday 16 of August 2012 12:08:08 Leela Krishna Amudala wrote: > +enum fimd_version_type { > + VERSION_8, /* FIMD_VERSION8 */ > +}; > + > +struct drm_f

[PATCH V3 1/2] drm/exynos: add platform_device_id table and driver data for exynos5 drm fimd

2012-09-04 Thread Leela Krishna Amudala
Hello Inki Dae, On Tue, Sep 4, 2012 at 7:45 PM, InKi Dae wrote: > 2012/8/16 Leela Krishna Amudala : >> The name of the exynos drm fimd device is renamed to exynos-drm-fimd >> and two device ids are created for exynos4-fb and exynos5-drm-fimd. >> Also, added driver data for exynos5 to pick the

[PATCH V3 1/2] drm/exynos: add platform_device_id table and driver data for exynos5 drm fimd

2012-09-04 Thread InKi Dae
2012/8/16 Leela Krishna Amudala : > The name of the exynos drm fimd device is renamed to exynos-drm-fimd > and two device ids are created for exynos4-fb and exynos5-drm-fimd. > Also, added driver data for exynos5 to pick the fimd version at runtime and > to choose the VIDTCON register offsets

Re: [PATCH V3 1/2] drm/exynos: add platform_device_id table and driver data for exynos5 drm fimd

2012-09-04 Thread InKi Dae
2012/8/16 Leela Krishna Amudala l.kris...@samsung.com: The name of the exynos drm fimd device is renamed to exynos-drm-fimd and two device ids are created for exynos4-fb and exynos5-drm-fimd. Also, added driver data for exynos5 to pick the fimd version at runtime and to choose the VIDTCON

Re: [PATCH V3 1/2] drm/exynos: add platform_device_id table and driver data for exynos5 drm fimd

2012-09-04 Thread Leela Krishna Amudala
Hello Inki Dae, On Tue, Sep 4, 2012 at 7:45 PM, InKi Dae inki@samsung.com wrote: 2012/8/16 Leela Krishna Amudala l.kris...@samsung.com: The name of the exynos drm fimd device is renamed to exynos-drm-fimd and two device ids are created for exynos4-fb and exynos5-drm-fimd. Also, added

[PATCH V3 1/2] drm/exynos: add platform_device_id table and driver data for exynos5 drm fimd

2012-08-17 Thread Leela Krishna Amudala
Hello, On Fri, Aug 17, 2012 at 6:18 AM, Joonyoung Shim wrote: > > Hi Leela. > > 2012/8/16 Leela Krishna Amudala : > > The name of the exynos drm fimd device is renamed to exynos-drm-fimd > > and two device ids are created for exynos4-fb and exynos5-drm-fimd. > > Also, added driver data for

[PATCH V3 1/2] drm/exynos: add platform_device_id table and driver data for exynos5 drm fimd

2012-08-17 Thread Joonyoung Shim
Hi Leela. 2012/8/16 Leela Krishna Amudala : > The name of the exynos drm fimd device is renamed to exynos-drm-fimd > and two device ids are created for exynos4-fb and exynos5-drm-fimd. > Also, added driver data for exynos5 to pick the fimd version at runtime and > to choose the VIDTCON register

[PATCH V3 1/2] drm/exynos: add platform_device_id table and driver data for exynos5 drm fimd

2012-08-17 Thread Leela Krishna Amudala
The name of the exynos drm fimd device is renamed to exynos-drm-fimd and two device ids are created for exynos4-fb and exynos5-drm-fimd. Also, added driver data for exynos5 to pick the fimd version at runtime and to choose the VIDTCON register offsets accordingly. Signed-off-by: Leela Krishna

Re: [PATCH V3 1/2] drm/exynos: add platform_device_id table and driver data for exynos5 drm fimd

2012-08-17 Thread Leela Krishna Amudala
Hello, On Fri, Aug 17, 2012 at 6:18 AM, Joonyoung Shim dofm...@gmail.com wrote: Hi Leela. 2012/8/16 Leela Krishna Amudala l.kris...@samsung.com: The name of the exynos drm fimd device is renamed to exynos-drm-fimd and two device ids are created for exynos4-fb and exynos5-drm-fimd. Also,

[PATCH V3 1/2] drm/exynos: add platform_device_id table and driver data for exynos5 drm fimd

2012-08-16 Thread Leela Krishna Amudala
The name of the exynos drm fimd device is renamed to exynos-drm-fimd and two device ids are created for exynos4-fb and exynos5-drm-fimd. Also, added driver data for exynos5 to pick the fimd version at runtime and to choose the VIDTCON register offsets accordingly. Signed-off-by: Leela Krishna

Re: [PATCH V3 1/2] drm/exynos: add platform_device_id table and driver data for exynos5 drm fimd

2012-08-16 Thread Joonyoung Shim
Hi Leela. 2012/8/16 Leela Krishna Amudala l.kris...@samsung.com: The name of the exynos drm fimd device is renamed to exynos-drm-fimd and two device ids are created for exynos4-fb and exynos5-drm-fimd. Also, added driver data for exynos5 to pick the fimd version at runtime and to choose the