Re: [PATCH drm-next v5 03/14] drm: manager to keep track of GPUs VA mappings

2023-06-26 Thread Dave Airlie
> > As pointed out by Christian, this would optimize the "get all mappings > > backed by a specific BO from a given VM" use case. > > > > The question for me is, do other drivers than amdgpu commonly need this? > > I have no idea. > > > > > And what does amdgpu need this for? Maybe amdgpu does some

Re: [PATCH drm-next v5 03/14] drm: manager to keep track of GPUs VA mappings

2023-06-23 Thread Christian König
Am 23.06.23 um 15:55 schrieb Danilo Krummrich: [SNIP] How do you efficiently find only the mappings of a BO in one VM? Actually, I think this case should even be more efficient than with a BO having a list of GPUVAs (or mappings): *than with a BO having a list of VMs: Having a list of GP

Re: [PATCH drm-next v5 03/14] drm: manager to keep track of GPUs VA mappings

2023-06-23 Thread Danilo Krummrich
On 6/23/23 09:16, Christian König wrote: Am 22.06.23 um 17:07 schrieb Danilo Krummrich: On 6/22/23 17:04, Danilo Krummrich wrote: On 6/22/23 16:42, Christian König wrote: Am 22.06.23 um 16:22 schrieb Danilo Krummrich: On 6/22/23 15:54, Christian König wrote: Am 20.06.23 um 14:23 schrieb Dani

Re: [PATCH drm-next v5 03/14] drm: manager to keep track of GPUs VA mappings

2023-06-23 Thread Christian König
Am 22.06.23 um 17:07 schrieb Danilo Krummrich: On 6/22/23 17:04, Danilo Krummrich wrote: On 6/22/23 16:42, Christian König wrote: Am 22.06.23 um 16:22 schrieb Danilo Krummrich: On 6/22/23 15:54, Christian König wrote: Am 20.06.23 um 14:23 schrieb Danilo Krummrich: Hi Christian, On 6/20/23 0

Re: [PATCH drm-next v5 03/14] drm: manager to keep track of GPUs VA mappings

2023-06-22 Thread Matthew Brost
On Thu, Jun 22, 2023 at 05:07:11PM +0200, Danilo Krummrich wrote: > On 6/22/23 17:04, Danilo Krummrich wrote: > > On 6/22/23 16:42, Christian König wrote: > > > Am 22.06.23 um 16:22 schrieb Danilo Krummrich: > > > > On 6/22/23 15:54, Christian König wrote: > > > > > Am 20.06.23 um 14:23 schrieb Dan

Re: [PATCH drm-next v5 03/14] drm: manager to keep track of GPUs VA mappings

2023-06-22 Thread Danilo Krummrich
On 6/22/23 17:04, Danilo Krummrich wrote: On 6/22/23 16:42, Christian König wrote: Am 22.06.23 um 16:22 schrieb Danilo Krummrich: On 6/22/23 15:54, Christian König wrote: Am 20.06.23 um 14:23 schrieb Danilo Krummrich: Hi Christian, On 6/20/23 08:45, Christian König wrote: Hi Danilo, sorry

Re: [PATCH drm-next v5 03/14] drm: manager to keep track of GPUs VA mappings

2023-06-22 Thread Danilo Krummrich
On 6/22/23 16:42, Christian König wrote: Am 22.06.23 um 16:22 schrieb Danilo Krummrich: On 6/22/23 15:54, Christian König wrote: Am 20.06.23 um 14:23 schrieb Danilo Krummrich: Hi Christian, On 6/20/23 08:45, Christian König wrote: Hi Danilo, sorry for the delayed reply. I've trying to dig m

Re: [PATCH drm-next v5 03/14] drm: manager to keep track of GPUs VA mappings

2023-06-22 Thread Christian König
Am 22.06.23 um 16:22 schrieb Danilo Krummrich: On 6/22/23 15:54, Christian König wrote: Am 20.06.23 um 14:23 schrieb Danilo Krummrich: Hi Christian, On 6/20/23 08:45, Christian König wrote: Hi Danilo, sorry for the delayed reply. I've trying to dig myself out of a hole at the moment. No w

Re: [PATCH drm-next v5 03/14] drm: manager to keep track of GPUs VA mappings

2023-06-22 Thread Danilo Krummrich
On 6/22/23 15:54, Christian König wrote: Am 20.06.23 um 14:23 schrieb Danilo Krummrich: Hi Christian, On 6/20/23 08:45, Christian König wrote: Hi Danilo, sorry for the delayed reply. I've trying to dig myself out of a hole at the moment. No worries, thank you for taking a look anyway! A

Re: [PATCH drm-next v5 03/14] drm: manager to keep track of GPUs VA mappings

2023-06-22 Thread Christian König
Am 20.06.23 um 14:23 schrieb Danilo Krummrich: Hi Christian, On 6/20/23 08:45, Christian König wrote: Hi Danilo, sorry for the delayed reply. I've trying to dig myself out of a hole at the moment. No worries, thank you for taking a look anyway! Am 20.06.23 um 02:42 schrieb Danilo Krummri

Re: [PATCH drm-next v5 03/14] drm: manager to keep track of GPUs VA mappings

2023-06-21 Thread Donald Robson
Hi Danilo, One comment below, but otherwise it looks great. Thanks for adding the example! Thanks, Donald On Tue, 2023-06-20 at 02:42 +0200, Danilo Krummrich wrote: > > +/** > + * DOC: Overview > + * > + * The DRM GPU VA Manager, represented by struct drm_gpuva_manager keeps > track > + * of a

Re: [PATCH drm-next v5 03/14] drm: manager to keep track of GPUs VA mappings

2023-06-20 Thread Danilo Krummrich
Hi Christian, On 6/20/23 08:45, Christian König wrote: Hi Danilo, sorry for the delayed reply. I've trying to dig myself out of a hole at the moment. No worries, thank you for taking a look anyway! Am 20.06.23 um 02:42 schrieb Danilo Krummrich: [SNIP] diff --git a/include/drm/drm_gem.h b

Re: [PATCH drm-next v5 03/14] drm: manager to keep track of GPUs VA mappings

2023-06-19 Thread Christian König
Hi Danilo, sorry for the delayed reply. I've trying to dig myself out of a hole at the moment. Am 20.06.23 um 02:42 schrieb Danilo Krummrich: [SNIP] diff --git a/include/drm/drm_gem.h b/include/drm/drm_gem.h index bbc721870c13..5ec8148a30ee 100644 --- a/include/drm/drm_gem.h +++ b/include/drm

Re: [PATCH drm-next v5 03/14] drm: manager to keep track of GPUs VA mappings

2023-06-19 Thread kernel test robot
: dcb0775d36de28992f56455ab3967b30d380 patch link:https://lore.kernel.org/r/20230620004217.4700-4-dakr%40redhat.com patch subject: [PATCH drm-next v5 03/14] drm: manager to keep track of GPUs VA mappings config: hexagon-randconfig-r041-20230620 (https://download.01.org/0day-ci/archive/20230620

Re: [PATCH drm-next v5 03/14] drm: manager to keep track of GPUs VA mappings

2023-06-19 Thread kernel test robot
: dcb0775d36de28992f56455ab3967b30d380 patch link:https://lore.kernel.org/r/20230620004217.4700-4-dakr%40redhat.com patch subject: [PATCH drm-next v5 03/14] drm: manager to keep track of GPUs VA mappings config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230620/202306201034.gucldv3r

[PATCH drm-next v5 03/14] drm: manager to keep track of GPUs VA mappings

2023-06-19 Thread Danilo Krummrich
Add infrastructure to keep track of GPU virtual address (VA) mappings with a decicated VA space manager implementation. New UAPIs, motivated by Vulkan sparse memory bindings graphics drivers start implementing, allow userspace applications to request multiple and arbitrary GPU VA mappings of buffe