Re: [PATCH hwc v1] drm_hwcomposer: Add CONTRIBUTING file

2017-09-28 Thread Eric Engestrom
On Wednesday, 2017-09-27 18:55:49 +, Robert Foss wrote: > > > +- When submitting new code please follow the naming conventions > > > documented > > > +  in the generated documentation. Also please make full use of all > > > the helpers and > > > +  convenience macros provided by

Re: [PATCH hwc v1] drm_hwcomposer: Add CONTRIBUTING file

2017-09-27 Thread Rob Herring
On Wed, Sep 27, 2017 at 1:55 PM, Robert Foss wrote: > Hey Emil, > > On Wed, 2017-09-27 at 15:42 +0100, Emil Velikov wrote: >> Hi Rob, >> >> Glad to see this. There's a couple of suggestions that I hope you'll >> find worth while. >> >> On 22 September 2017 at 01:37,

Re: [PATCH hwc v1] drm_hwcomposer: Add CONTRIBUTING file

2017-09-27 Thread Robert Foss
Hey Emil, On Wed, 2017-09-27 at 15:42 +0100, Emil Velikov wrote: > Hi Rob, > > Glad to see this. There's a couple of suggestions that I hope you'll > find worth while. > > On 22 September 2017 at 01:37, Robert Foss > wrote: > > Some basic guidelines for

Re: [PATCH hwc v1] drm_hwcomposer: Add CONTRIBUTING file

2017-09-27 Thread Emil Velikov
Hi Rob, Glad to see this. There's a couple of suggestions that I hope you'll find worth while. On 22 September 2017 at 01:37, Robert Foss wrote: > Some basic guidelines for contributions could come in handy. > > These are copied from IGT and modified to be suitable. >

Re: [PATCH hwc v1] drm_hwcomposer: Add CONTRIBUTING file

2017-09-22 Thread Robert Foss
Pushed! On Fri, 2017-09-22 at 09:23 -0700, Sean Paul wrote: > On Fri, Sep 22, 2017 at 02:37:18AM +0200, Robert Foss wrote: > > Some basic guidelines for contributions could come in handy. > > > > These are copied from IGT and modified to be suitable. > > > > Signed-off-by: Robert Foss

Re: [PATCH hwc v1] drm_hwcomposer: Add CONTRIBUTING file

2017-09-22 Thread Sean Paul
On Fri, Sep 22, 2017 at 02:37:18AM +0200, Robert Foss wrote: > Some basic guidelines for contributions could come in handy. > > These are copied from IGT and modified to be suitable. > > Signed-off-by: Robert Foss > --- > CONTRIBUTING | 31

Re: [PATCH hwc v1] drm_hwcomposer: Add CONTRIBUTING file

2017-09-22 Thread Zach Reizner
On Thu, Sep 21, 2017 at 5:37 PM, Robert Foss wrote: > Some basic guidelines for contributions could come in handy. > > These are copied from IGT and modified to be suitable. > > Signed-off-by: Robert Foss Reviewed-by: Zach Reizner

[PATCH hwc v1] drm_hwcomposer: Add CONTRIBUTING file

2017-09-21 Thread Robert Foss
Some basic guidelines for contributions could come in handy. These are copied from IGT and modified to be suitable. Signed-off-by: Robert Foss --- CONTRIBUTING | 31 +++ 1 file changed, 31 insertions(+) create mode 100644 CONTRIBUTING