Re: [PATCH hwc v2 1/6] drm_hwcomposer: Remove threading

2017-09-29 Thread Robert Foss
On Fri, 2017-09-29 at 17:07 +0800, Chih-Wei Huang wrote: > 2017-09-29 16:44 GMT+08:00 Robert Foss : > > On Fri, 2017-09-29 at 13:49 +0800, Chih-Wei Huang wrote: > > > 2017-09-29 5:29 GMT+08:00 Rob Herring : > > > > Perhaps just leave the current state as a separate branch. > > > > > > Did you mean

Re: [PATCH hwc v2 1/6] drm_hwcomposer: Remove threading

2017-09-29 Thread Chih-Wei Huang
2017-09-29 16:44 GMT+08:00 Robert Foss : > On Fri, 2017-09-29 at 13:49 +0800, Chih-Wei Huang wrote: >> 2017-09-29 5:29 GMT+08:00 Rob Herring : >> > Perhaps just leave the current state as a separate branch. >> >> Did you mean we maintain the branch in our repo? >> (that's what we do now, but I hope

Re: [PATCH hwc v2 1/6] drm_hwcomposer: Remove threading

2017-09-29 Thread Robert Foss
On Fri, 2017-09-29 at 13:49 +0800, Chih-Wei Huang wrote: > 2017-09-29 5:29 GMT+08:00 Rob Herring : > > On Thu, Sep 28, 2017 at 11:43 AM, Chih-Wei Huang > > wrote: > > > 2017-09-27 19:58 GMT+08:00 Robert Foss > > >: > > > > From: Sean Paul > > > > > > > > Since HWC2 doesn't require the use of th

Re: [PATCH hwc v2 1/6] drm_hwcomposer: Remove threading

2017-09-28 Thread Chih-Wei Huang
2017-09-29 5:29 GMT+08:00 Rob Herring : > On Thu, Sep 28, 2017 at 11:43 AM, Chih-Wei Huang > wrote: >> 2017-09-27 19:58 GMT+08:00 Robert Foss : >>> From: Sean Paul >>> >>> Since HWC2 doesn't require the use of threads to implement correct >>> synchronization, remove some of these threads. >> >> M

Re: [PATCH hwc v2 1/6] drm_hwcomposer: Remove threading

2017-09-28 Thread Rob Herring
On Thu, Sep 28, 2017 at 11:43 AM, Chih-Wei Huang wrote: > 2017-09-27 19:58 GMT+08:00 Robert Foss : >> From: Sean Paul >> >> Since HWC2 doesn't require the use of threads to implement correct >> synchronization, remove some of these threads. > > May I ask to avoid HWC2 only implementation? > The m

Re: [PATCH hwc v2 1/6] drm_hwcomposer: Remove threading

2017-09-28 Thread Chih-Wei Huang
2017-09-27 19:58 GMT+08:00 Robert Foss : > From: Sean Paul > > Since HWC2 doesn't require the use of threads to implement correct > synchronization, remove some of these threads. May I ask to avoid HWC2 only implementation? The main reason is not all GPUs support drm_hwcompser (as discussed in an

Re: [PATCH hwc v2 1/6] drm_hwcomposer: Remove threading

2017-09-28 Thread Robert Foss
On Wed, 2017-09-27 at 15:14 -0400, Sean Paul wrote: > On Wed, Sep 27, 2017 at 7:58 AM, Robert Foss om> wrote: > > From: Sean Paul > > > > Since HWC2 doesn't require the use of threads to implement correct > > synchronization, remove some of these threads. > > > > My SoB seems to have been drop

Re: [PATCH hwc v2 1/6] drm_hwcomposer: Remove threading

2017-09-27 Thread Sean Paul
On Wed, Sep 27, 2017 at 7:58 AM, Robert Foss wrote: > From: Sean Paul > > Since HWC2 doesn't require the use of threads to implement correct > synchronization, remove some of these threads. > My SoB seems to have been dropped (or perhaps I just forgot to add it in the original thread). At any ra

Re: [PATCH hwc v2 1/6] drm_hwcomposer: Remove threading

2017-09-27 Thread Robert Foss
Hey Emil, On Wed, 2017-09-27 at 14:34 +0100, Emil Velikov wrote: > On 27 September 2017 at 12:58, Robert Foss > wrote: > > >  16 files changed, 93 insertions(+), 724 deletions(-) > > Holly smokes, that's some amazing stat. > Please sir can I have some more ;-) > > Question - this patch removes

Re: [PATCH hwc v2 1/6] drm_hwcomposer: Remove threading

2017-09-27 Thread Emil Velikov
On 27 September 2017 at 12:58, Robert Foss wrote: > 16 files changed, 93 insertions(+), 724 deletions(-) Holly smokes, that's some amazing stat. Please sir can I have some more ;-) Question - this patch removes the threading implementation, while the actual substitute lands with patches 2-6. D

[PATCH hwc v2 1/6] drm_hwcomposer: Remove threading

2017-09-27 Thread Robert Foss
From: Sean Paul Since HWC2 doesn't require the use of threads to implement correct synchronization, remove some of these threads. Signed-off-by: Robert Foss --- Android.mk| 3 - drmcomposition.cpp| 166 drmcomposition.h