[PATCH i915 v7 1/2] i915: wait for fence in mmio_flip_work_func

2015-11-25 Thread Daniel Kurtz
Hi Alex, Drive-by review because I was just reviewing something similar for a different device... On Wed, Nov 25, 2015 at 6:15 AM, Alex Goins wrote: > If a buffer is backed by dmabuf, wait on its reservation object's exclusive > fence before flipping. > > v2: First commit > v3: Remove object_nam

[PATCH i915 v7 1/2] i915: wait for fence in mmio_flip_work_func

2015-11-25 Thread Daniel Vetter
On Tue, Nov 24, 2015 at 06:26:00PM -0800, Alex Goins wrote: > Thanks, Daniel. There sure are a lot of Daniels. > > > > + else if (obj->base.dma_buf && obj->base.dma_buf->resv->fence_excl) > > > + return true; > > > > I'm not sure if this is really doing exactly what you want.

[PATCH i915 v7 1/2] i915: wait for fence in mmio_flip_work_func

2015-11-24 Thread Alex Goins
Thanks, Daniel. There sure are a lot of Daniels. > > + else if (obj->base.dma_buf && obj->base.dma_buf->resv->fence_excl) > > + return true; > > I'm not sure if this is really doing exactly what you want. > When a reservation object's exclusive fence has signaled, I think the

[PATCH i915 v7 1/2] i915: wait for fence in mmio_flip_work_func

2015-11-24 Thread Alex Goins
If a buffer is backed by dmabuf, wait on its reservation object's exclusive fence before flipping. v2: First commit v3: Remove object_name_lock acquire v4: Move wait ahead of mark_page_flip_active Use crtc->primary->fb to get GEM object instead of pending_flip_obj use_mmio_flip() return tr