Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-07-16 Thread Dmitry Osipenko
On 7/15/22 18:18, Andrey Grodzovsky wrote: > > On 2022-07-14 17:16, Alex Deucher wrote: >> On Thu, Jul 14, 2022 at 1:58 PM Andrey Grodzovsky >> wrote: >>> On 2022-07-14 12:22, Alex Deucher wrote: >>> On Thu, Jul 14, 2022 at 10:14 AM Andrey Grodzovsky wrote: > On 2022-07-14 05:57, D

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-07-16 Thread Andrey Grodzovsky
On 2022-07-14 17:16, Alex Deucher wrote: On Thu, Jul 14, 2022 at 1:58 PM Andrey Grodzovsky wrote: On 2022-07-14 12:22, Alex Deucher wrote: On Thu, Jul 14, 2022 at 10:14 AM Andrey Grodzovsky wrote: On 2022-07-14 05:57, Dmitry Osipenko wrote: On 7/12/22 11:56, Dmitry Osipenko wrote: On 7/

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-07-14 Thread Alex Deucher
On Thu, Jul 14, 2022 at 1:58 PM Andrey Grodzovsky wrote: > > On 2022-07-14 12:22, Alex Deucher wrote: > > > On Thu, Jul 14, 2022 at 10:14 AM Andrey Grodzovsky > > wrote: > >> > >> On 2022-07-14 05:57, Dmitry Osipenko wrote: > >>> On 7/12/22 11:56, Dmitry Osipenko wrote: > On 7/6/22 18:46, Al

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-07-14 Thread Andrey Grodzovsky
On 2022-07-14 12:22, Alex Deucher wrote: On Thu, Jul 14, 2022 at 10:14 AM Andrey Grodzovsky wrote: On 2022-07-14 05:57, Dmitry Osipenko wrote: On 7/12/22 11:56, Dmitry Osipenko wrote: On 7/6/22 18:46, Alex Deucher wrote: On Wed, Jul 6, 2022 at 9:49 AM Andrey Grodzovsky wrote: On 2022-07-

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-07-14 Thread Alex Deucher
On Thu, Jul 14, 2022 at 10:14 AM Andrey Grodzovsky wrote: > > > On 2022-07-14 05:57, Dmitry Osipenko wrote: > > On 7/12/22 11:56, Dmitry Osipenko wrote: > >> On 7/6/22 18:46, Alex Deucher wrote: > >>> On Wed, Jul 6, 2022 at 9:49 AM Andrey Grodzovsky > >>> wrote: > On 2022-07-06 03:07, Dmitry

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-07-14 Thread Dmitry Osipenko
On 7/14/22 17:14, Andrey Grodzovsky wrote: > > On 2022-07-14 05:57, Dmitry Osipenko wrote: >> On 7/12/22 11:56, Dmitry Osipenko wrote: >>> On 7/6/22 18:46, Alex Deucher wrote: On Wed, Jul 6, 2022 at 9:49 AM Andrey Grodzovsky wrote: > On 2022-07-06 03:07, Dmitry Osipenko wrote: >

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-07-14 Thread Andrey Grodzovsky
On 2022-07-14 05:57, Dmitry Osipenko wrote: On 7/12/22 11:56, Dmitry Osipenko wrote: On 7/6/22 18:46, Alex Deucher wrote: On Wed, Jul 6, 2022 at 9:49 AM Andrey Grodzovsky wrote: On 2022-07-06 03:07, Dmitry Osipenko wrote: Hello Andrey, On 5/17/22 17:48, Dmitry Osipenko wrote: On 5/17/22

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-07-14 Thread Dmitry Osipenko
On 7/12/22 11:56, Dmitry Osipenko wrote: > On 7/6/22 18:46, Alex Deucher wrote: >> On Wed, Jul 6, 2022 at 9:49 AM Andrey Grodzovsky >> wrote: >>> >>> On 2022-07-06 03:07, Dmitry Osipenko wrote: >>> Hello Andrey, On 5/17/22 17:48, Dmitry Osipenko wrote: > On 5/17/22 17:13, Andrey

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-07-12 Thread Dmitry Osipenko
On 7/6/22 18:46, Alex Deucher wrote: > On Wed, Jul 6, 2022 at 9:49 AM Andrey Grodzovsky > wrote: >> >> On 2022-07-06 03:07, Dmitry Osipenko wrote: >> >>> Hello Andrey, >>> >>> On 5/17/22 17:48, Dmitry Osipenko wrote: On 5/17/22 17:13, Andrey Grodzovsky wrote: > Done. > > Andrey >>

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-07-06 Thread Alex Deucher
On Wed, Jul 6, 2022 at 9:49 AM Andrey Grodzovsky wrote: > > On 2022-07-06 03:07, Dmitry Osipenko wrote: > > > Hello Andrey, > > > > On 5/17/22 17:48, Dmitry Osipenko wrote: > >> On 5/17/22 17:13, Andrey Grodzovsky wrote: > >>> Done. > >>> > >>> Andrey > >> Awesome, thank you! > >> > > Given that t

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-07-06 Thread Dmitry Osipenko
On 7/6/22 16:49, Andrey Grodzovsky wrote: > On 2022-07-06 03:07, Dmitry Osipenko wrote: > >> Hello Andrey, >> >> On 5/17/22 17:48, Dmitry Osipenko wrote: >>> On 5/17/22 17:13, Andrey Grodzovsky wrote: Done. Andrey >>> Awesome, thank you! >>> >> Given that this drm-scheduler issue ne

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-07-06 Thread Andrey Grodzovsky
On 2022-07-06 03:07, Dmitry Osipenko wrote: Hello Andrey, On 5/17/22 17:48, Dmitry Osipenko wrote: On 5/17/22 17:13, Andrey Grodzovsky wrote: Done. Andrey Awesome, thank you! Given that this drm-scheduler issue needs to be fixed in the 5.19-RC and earlier, shouldn't it be in the drm-fixes

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-07-06 Thread Dmitry Osipenko
Hello Andrey, On 5/17/22 17:48, Dmitry Osipenko wrote: > On 5/17/22 17:13, Andrey Grodzovsky wrote: >> Done. >> >> Andrey > > Awesome, thank you! > Given that this drm-scheduler issue needs to be fixed in the 5.19-RC and earlier, shouldn't it be in the drm-fixes and not in drm-next? -- Best r

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-05-17 Thread Dmitry Osipenko
On 5/17/22 17:13, Andrey Grodzovsky wrote: > Done. > > Andrey Awesome, thank you! -- Best regards, Dmitry

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-05-17 Thread Andrey Grodzovsky
Done. Andrey On 2022-05-17 10:03, Andrey Grodzovsky wrote: Let me push it into drm-misc-next. Andrey On 2022-05-17 05:03, Dmitry Osipenko wrote: On 5/17/22 10:40, Erico Nunes wrote: On Wed, Apr 13, 2022 at 12:05 PM Steven Price wrote: On 11/04/2022 23:15, Dmitry Osipenko wrote: Interrupt

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-05-17 Thread Andrey Grodzovsky
Let me push it into drm-misc-next. Andrey On 2022-05-17 05:03, Dmitry Osipenko wrote: On 5/17/22 10:40, Erico Nunes wrote: On Wed, Apr 13, 2022 at 12:05 PM Steven Price wrote: On 11/04/2022 23:15, Dmitry Osipenko wrote: Interrupt context can't sleep. Drivers like Panfrost and MSM are takin

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-05-17 Thread Dmitry Osipenko
On 5/17/22 10:40, Erico Nunes wrote: > On Wed, Apr 13, 2022 at 12:05 PM Steven Price wrote: >> >> On 11/04/2022 23:15, Dmitry Osipenko wrote: >>> Interrupt context can't sleep. Drivers like Panfrost and MSM are taking >>> mutex when job is released, and thus, that code can sleep. This results >>>

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-05-17 Thread Erico Nunes
On Wed, Apr 13, 2022 at 12:05 PM Steven Price wrote: > > On 11/04/2022 23:15, Dmitry Osipenko wrote: > > Interrupt context can't sleep. Drivers like Panfrost and MSM are taking > > mutex when job is released, and thus, that code can sleep. This results > > into "BUG: scheduling while atomic" if lo

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-04-13 Thread Steven Price
On 11/04/2022 23:15, Dmitry Osipenko wrote: > Interrupt context can't sleep. Drivers like Panfrost and MSM are taking > mutex when job is released, and thus, that code can sleep. This results > into "BUG: scheduling while atomic" if locks are contented while job is > freed. There is no good reason

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-04-13 Thread Erico Nunes
On Wed, Apr 13, 2022 at 8:05 AM Dmitry Osipenko wrote: > > On 4/13/22 01:59, Erico Nunes wrote: > > On Tue, Apr 12, 2022 at 9:41 PM Andrey Grodzovsky > > wrote: > >> > >> > >> On 2022-04-12 14:20, Dmitry Osipenko wrote: > >>> On 4/12/22 19:51, Andrey Grodzovsky wrote: > On 2022-04-11 18:15,

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-04-12 Thread Dmitry Osipenko
On 4/13/22 01:59, Erico Nunes wrote: > On Tue, Apr 12, 2022 at 9:41 PM Andrey Grodzovsky > wrote: >> >> >> On 2022-04-12 14:20, Dmitry Osipenko wrote: >>> On 4/12/22 19:51, Andrey Grodzovsky wrote: On 2022-04-11 18:15, Dmitry Osipenko wrote: > Interrupt context can't sleep. Drivers like P

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-04-12 Thread Erico Nunes
On Tue, Apr 12, 2022 at 9:41 PM Andrey Grodzovsky wrote: > > > On 2022-04-12 14:20, Dmitry Osipenko wrote: > > On 4/12/22 19:51, Andrey Grodzovsky wrote: > >> On 2022-04-11 18:15, Dmitry Osipenko wrote: > >>> Interrupt context can't sleep. Drivers like Panfrost and MSM are taking > >>> mutex when

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-04-12 Thread Dmitry Osipenko
On 4/12/22 22:40, Andrey Grodzovsky wrote: > > On 2022-04-12 14:20, Dmitry Osipenko wrote: >> On 4/12/22 19:51, Andrey Grodzovsky wrote: >>> On 2022-04-11 18:15, Dmitry Osipenko wrote: Interrupt context can't sleep. Drivers like Panfrost and MSM are taking mutex when job is released, and

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-04-12 Thread Andrey Grodzovsky
On 2022-04-12 14:20, Dmitry Osipenko wrote: On 4/12/22 19:51, Andrey Grodzovsky wrote: On 2022-04-11 18:15, Dmitry Osipenko wrote: Interrupt context can't sleep. Drivers like Panfrost and MSM are taking mutex when job is released, and thus, that code can sleep. This results into "BUG: schedul

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-04-12 Thread Dmitry Osipenko
On 4/12/22 19:51, Andrey Grodzovsky wrote: > > On 2022-04-11 18:15, Dmitry Osipenko wrote: >> Interrupt context can't sleep. Drivers like Panfrost and MSM are taking >> mutex when job is released, and thus, that code can sleep. This results >> into "BUG: scheduling while atomic" if locks are conte

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-04-12 Thread Andrey Grodzovsky
On 2022-04-11 18:15, Dmitry Osipenko wrote: Interrupt context can't sleep. Drivers like Panfrost and MSM are taking mutex when job is released, and thus, that code can sleep. This results into "BUG: scheduling while atomic" if locks are contented while job is freed. There is no good reason for

[PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-04-11 Thread Dmitry Osipenko
Interrupt context can't sleep. Drivers like Panfrost and MSM are taking mutex when job is released, and thus, that code can sleep. This results into "BUG: scheduling while atomic" if locks are contented while job is freed. There is no good reason for releasing scheduler's jobs in IRQ context, hence